Re: [XEN PATCH] x86/processor: drop bool_t from mcheck_init() parameter

[Federico Serafini <federico.serafini@xxxxxxxxxxx>]

On 04/08/23 12:56, Federico Serafini wrote:
> Drop bool_t to make the function declaration consistent with the
> corresponding definition.
> This addresses a violation of MISRA C:2012 Rule 8.3 ("All declarations
> of an object or function shall use the same names and type qualifiers").
>
> No functional change.
>
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
> ---
>   xen/arch/x86/include/asm/processor.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/include/asm/processor.h 
> b/xen/arch/x86/include/asm/processor.h
> index 0989748be6..ae43ba5dc9 100644
> --- a/xen/arch/x86/include/asm/processor.h
> +++ b/xen/arch/x86/include/asm/processor.h
> @@ -415,7 +415,7 @@ void noreturn fatal_trap(const struct cpu_user_regs *regs, 
> bool_t show_remote);
>   extern void mtrr_ap_init(void);
>   extern void mtrr_bp_init(void);
>   
> -void mcheck_init(struct cpuinfo_x86 *c, bool_t bsp);
> +void mcheck_init(struct cpuinfo_x86 *c, bool bsp);
>   
>   void do_nmi(const struct cpu_user_regs *regs);
>   void do_machine_check(const struct cpu_user_regs *regs);
I can do better and drop bool_t from the entire file.
I will do it in a v2.

--
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)