[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 5/6] x86/xstate: address MISRA C:2012 Rule 5.3
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Aug 2023 10:23:20 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8ftNqEZHQAKAYL98A+V7QlXNmwwmyKY0cQXST6QNRhg=; b=Sc1Wob8ymz6u+h9UpgB8in1EPtaWgM3eiJMAuU4CjE6NJkFoYSRZABdU98oCoh+zZO98q5LrJvMm7RG9UobdBSgHdbVnndVOThuoDoGqHFmqc83ln10ja3yRtMT1+AYaj0PjE+FBiTj9bfqkNA1oQq0+KFlgsO6gW04SwVibcsvYTuEpXnpTJ9K+bKY7ZfPeLEYnktqRnhLaLMVcl207f7dnU2ag/ve681+0QJSSEAROd6RHHNG7hghRI+VeHRyWqDVpsDhwEdmDSNQ2f1a+j9DxmN/PX4igsQ+ZHXRmWBghX2SCgTks4HNXNz4fSmPZ7AxIAyZk8eLRQq7uulJtUw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bEmaT4TTIK0Mfo586HrMGDe88Rrf9Z3hNoISBrvLb5PdOpoOfWnkCJNacf2fjoVWy2NZp78bLA3lafIbqjG78zbKrKzNjnw3UDVztz9W6LleMDHpDLwznN/xa69R7Gyh5NfgWaTrq9A7fTigyMmtnvFpspD5GBt5GjenS6zgWTnRm8PqAYfQTITmXSTQTdXExrMSMW8NlxRiqPWGjvt5X14VltDaPCfADpjMrzPUiDmE0Om9yLqqpR3VI8nRJVhqLKEjE+7dTd/ZVR6Xb/qCgbXe2aLSUfoyCxJ4Oi7fCmRrXMrvvqSB+6//uHfePUzV5w1aztWHzfuVj1rmprloyg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 07 Aug 2023 08:23:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.08.2023 17:27, Nicola Vetrini wrote:
> Rename the local variables to avoid clashing with function 'xstate'
> defined below, but declared in the corresponding header file.
Hmm, there are two functions with such a local variable, but you don't
change those. You change "xsave" instead. The new name you use you took
from older functions afaict; newer ones use "xstate" (and use of this
name is extended in pending patches), so preferably we would follow
that naming model (and eventually rename all "xsave_area" as well).
Also - does "below" really matter and hence warrant the "but"?
Jan
|
