[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm
- To: Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayankuma@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 7 Aug 2023 11:54:24 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T1X5C/qh14GlZuXhXyVYEqvM8mfJnjsB9yJtw/H8xng=; b=oa8Pm44Qcc3AwoTUa2DK7b7B8knHkeFdgNbWyd5mg/zZNRFJeQ0hpWrClsyQpcEFzVOmqB7c7L/ZgEcoM5mHCm7EyrqQlX50lfWianVu0rDW/ZaqHcDngRFYqsDhCyqO+4wFmhcyxsFt17/0iMXNDePn4ggwfEXW3BGgEhWj31nkGBXkoJ/rFTb8iI+vq/yIn0xB8VQsgjVGf6Wvs0aKndJtSj8Mhos22MZmzpzeA4QYvFdo9nXwqklikJTXedMkwnU/xjTVYqiEg73jDYE3ZxmgKUw8ODt6hOXrbpnkZ++xi+ocj11xCt3zE6j3rSG3kPQ06BOiW6CevOlMJqnrvg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WYNwLyVmuzpHjnzudCEU3mBNaY/F5sCvCJQ9MD2Vbz33rUtuVvnwRLw0BiGJeksONhyLakpPV64ZaldB6NMqAds946vya3JIrY0IQ67HDZhcp460pRhOcIC/qchgKky55YKi6sBZ+RSqVImsTMavsxkhjihXS70vPalBwDHewYYoeBhtPeZCeJPz2EPQ45ZTDKPH3eGAbBCpT2OnXDr+JuB2FcdiRr3tnWcTHg9z2217IKO5Nu/USWS98LgHp/50Kn5U3EQ0x2ZbKdZ807hITE1U9seu9HO3nzKd9o2MlJUc+4sqcmPqpi9uRyB+qRglNNHKObcJvmqsrgi0erSl6w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- Delivery-date: Mon, 07 Aug 2023 11:56:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZxCqBtZIUxf7FmUaIEyO8EPs3TK/euu6AgAABikCAAAQOAIAAAf9g
- Thread-topic: [PATCH v4 01/13] xen/arm64: head.S: Introduce enable_{boot,secondary}_cpu_mm
Hi Julien,
> -----Original Message-----
> Subject: Re: [PATCH v4 01/13] xen/arm64: head.S: Introduce
> enable_{boot,secondary}_cpu_mm
> >> prefer "enable_boot_cpu_mmu" as it is MMU specific as well.
> >
> > ...this, are the name suggested by Julien in [1], so probably I will stick
> > to these names, unless he would prefer the proposed names. I would
> > personally prefer the names that Julien suggested too, because from
> > the comments above these two functions, these functions not only
> > enable the MMU, but also turn on the d-cache, hence a more generic
> > name (using "mm"), is more appropriate here I guess.
>
> I have suggested those name because the two functions are meant to
> abstract the implementation between MPU and MMU (see [2] for the MPU).
>
> If we prefix them with *_mmu now, they will have to be renamed later on
> and will just introduce unnecessary churn.
Exactly, I fully agree with you. If we can do all the renaming in one shot to
fit
both MMU and MPU, we should definitely go for it.
Kind regards,
Henry
>
> >
> > [1] https://lore.kernel.org/xen-devel/c10bc254-ad79-dada-d5fb-
> 9ee619934ffb@xxxxxxx/
>
> [2]
> https://gitlab.com/xen-project/people/henryw/xen/-
> /blob/mpu_v4/xen/arch/arm/arm64/mpu/head.S?ref_type=heads#L205
>
> --
> Julien Grall
|
