[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: Drop opt_pku entirely
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 7 Aug 2023 14:21:24 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wbwdwUYbSmncgELkjSuam2FjUmRyNBwN5M+qmKUJ+9w=; b=dQbeWjnq0VafQa5sLmwGDjie366oRh+LWyjjNLlsKCBsqhjF2S2CLXPyv+iw69sBv3HZ/NoecO87jekE9YBP2FPF3Yo2NczMTP5x7PyDU4UoZT7dI/ApXYSpGYT5o3HMaL6P1r3Ij5FWjhgPBJ7Dwd/3/KNpoKoPCYiBNRv1EIX9cf9ozI1rZidS4SV2LWJPvAUNTI4lOKFTMHbw7+3oIi656IY1vQvhIlVF1ItNESmMEPuS6NhyeTU69ymP+2mvF0Zr3pFhSBEiWTBbfoiKf/u139u7/Jg66UH+DdPjxelCeGrfgvERee3NtrDgiVIWCYPvn+sghhVNam6HiMFr8Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MON3IxxoAS1ajR3iKRckyouIR46ne9G6xi+eEAjD4AsLgN9RsFVbdGp+Gn0MbbP8vLea9xJOptFiNAnchOz7DLi76kKYjFpKDkywyZ3he6uQh6v/PExARssptFWuaMKaF4t/8kiq901QZcjOYD4ejzRnQ6QYLLwRcrMlbtt7uCFGIIyNI6X31oN01q82zV1m8i2uL/OvFS0GFt9EsKssaVmu6AW1V09+oQZwZKejylEoBLKl8AMo/aQTNeULHXSQM4kElUQaQWi9bzHE21Yx5dLTYOpcVgogv3Rv0q1mVAOlg+NRuffskPKxw94fe4vFvEc3d6zDrgtGbWZMA/nEag==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 07 Aug 2023 13:21:43 +0000
- Ironport-data: A9a23:z5wKEqyLNaMEbSWpVk16t+cOxyrEfRIJ4+MujC+fZmUNrF6WrkVUn 2oZUG+DPPbea2OjLdF0OYvj8EoBvpPUmN5qSwY5qyAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRuPa8T5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KURN+ No6FAsUVCzAhO3ny+vkQ/BIt8t2eaEHPKtH0p1h5RfwKK9+BLzmHeDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjiVlVQtuFTuGIO9ltiibMNZhEuH4 EnB+Hz0GEoyP92D0zuVtHmrg4cjmAuiAdJMTOfjrq4CbFu7z1ciUkc8C0GHuuDjjnenYPdBA E0q5X97xUQ13AnxJjXnZDW6qnOZuh8XW/JLDvY3rgqKz8L8/AKxFmUCCDlbZ7QOlMIwXy1s6 VaPkPvgHzkpu7qQIVqN+7HRoT6sNCw9KW4ZeTRCXQYD+8Pkoow4klTIVNkLLUKuptj8GDW1z zXUqiE73u0XlZRSj/n9+k3biTWxoJSPVhQy+gjcQmOi6EV+eZKhYIurr1Pc6J6sMbqkc7VIh 1Bc8+D20QzEJcvlePClKAnVIIyU2g==
- Ironport-hdrordr: A9a23:VUWJla0lpLM/NWRukjSiZAqjBa9xeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtj4fZquz+8T3WB3B8beYOCGghrTEGgG1+ffKlLbak7DH4JmpM Jdmu1FeabN5DtB/LjHCWuDc+rIqePvmM7IuQ6d9QYUcegDUdAe0+4TMHf+LqQZfnghOXN0Lu v/2iIRzADQBUj/I/7LTkXsGIP41q/2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbfyJTzawk+W 3llRW8wqm4qfm0xjLVymeWtv1t6Zfc4+oGIPbJptkeKz3qhArtTIN9W4eatDRwjPCz5E0smN zspQ5lG8ho8Xvecky8vBOo8Qj91zQF7WPk1Daj8DbeiP28YAh/J9tKhIpffBecw008vOtk2K YO+26CrZJYAT7JgSy4vrHzJltXv3vxhUBnvf8YjnRZX4dbQLhNrbYH9EcQNJsbBir15K0uDe ErJsDB4/R9d0+cchnizyJS6e3pek52MgaNQ0AEtMDQ+z9KnEphx09d/8AblmdozuNLd7B0o8 D/doh4nrBHScEbKYhnAv0afMexAmvRBTrRLWO7Oz3cZeE6EkOIj6SyzKQ+5emsdpBN5oA1go 79XFRRsnN3U17yCPeJwIZA/nn2MSSAtAzWu4NjDqVCy/jBrOKBC1zGdLluqbrvnxwnOLyZZx 7pU6gmRMMKLgPVaPJ0NkPFKt9vwEIlIb4oU+YAKiOzS/3wW/3XX8zgAYDuzenWYH8Zc1K6JE c/dx7OA+gFxnyXexbD8W3ssjXWCwPCwa4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21/06/2023 8:37 am, Jan Beulich wrote:
> On 20.06.2023 19:47, Andrew Cooper wrote:
>> --- a/CHANGELOG.md
>> +++ b/CHANGELOG.md
>> @@ -25,6 +25,9 @@ The format is based on [Keep a
>> Changelog](https://keepachangelog.com/en/1.0.0/)
>> - Add support for AVX512-FP16 on x86.
>> - On Arm, Xen supports guests running SVE/SVE2 instructions. (Tech Preview)
>>
>> +### Removed
>> + - On x86, the "pku" command line option has been removed. It has never
>> + behaved precisely as described, and redundant with "cpuid=no-pku".
> Nit: Missing "was"?
Fixed
>
>> --- a/docs/misc/xen-command-line.pandoc
>> +++ b/docs/misc/xen-command-line.pandoc
>> @@ -1950,16 +1950,6 @@ for all of them (`true`), only for those subject to
>> XPTI (`xpti`) or for
>> those not subject to XPTI (`no-xpti`). The feature is used only in case
>> INVPCID is supported and not disabled via `invpcid=false`.
>>
>> -### pku (x86)
>> -> `= <boolean>`
>> -
>> -> Default: `true`
>> -
>> -Flag to enable Memory Protection Keys.
>> -
>> -The protection-key feature provides an additional mechanism by which IA-32e
>> -paging controls access to usermode addresses.
>> -
>> ### ple_gap
>> > `= <integer>`
> Elsewhere you said that we kind of imply that only the explicitly named
> sub-options of cpuid= are supported. If that's the case (which could do
> with saying more explicitly), you will want to add "pku" there in order
> to not regress what is (deemed) supported.
I disagree. I can say it was equivalent to X without X being an
explicitly supported option.
PKU shouldn't be adjusted by either of these options; it should be
controlled in the VM config file (if at all). I'm unwilling to make any
suggestion that this is supported.
~Andrew
|
