[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] xen/ppc: Parse device tree for OPAL node on PowerNV
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Aug 2023 16:59:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vjjszNJAg1agTj1Mvzb83fMug2Tcw1mS6kh4T4FWQNQ=; b=K4wGWVXoCu1uEfXNTsea68e4jJyRNKlPHn+CyZg0sbTAVenU1LcarlPUcyAHfnmgDPb0as0shNd7o+tqgWc8AZWGVvcHw7YJ0bzzqXrONH8StBDsAppauZjtp1tS2pGxxxhMRmmc7poTJNHB3TyHsXy0BG0f1UKDauohBXsjSZmPas4T0HSyj52uBSUlFw35kEPnzsdsONPrJWYpLHuf2Q73gJp5dthvEQ2hDutXtRtpId26qb0dSAmSbnxQOyKoixJgGmRtybilSuESgCYHn+wvzmKBpMRSK634Y0otFhWnThK9dTAWjMwG6cgfXt2WgZRPDBEiibcWPSBBijLn3w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mqgEj1UJwAmVPmwhFXOsU/5wQIt+KbkQJ/knDLSG8oLsNyUTy6GG9t0Iy+OVWmvIYNDsQOsRepCahOH6Q8+XcKDCHm4ODFX6cvSBYC4YCW6UZ75NJDBg2GF5ly3QoaYeeEwv85rKvjadFP/B6JAeP25lLIB4MxmsMpQi0DPnqhe3fORZW7EcPxL96jlyZmWopJn6YbpM2zyo9CcTPtO4YOURDb8KNWXXbU0YUkbOH06dvZaVMRZ8uMXngAcplAOqPWjhebFx3YTbY9eqvqmsWacYl3BLq6f0YOLvuFUeN5KrRpYs/zTUIlU+AFRfPGfoLbQwJNThk00wR7CakuKMvg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 07 Aug 2023 14:59:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.08.2023 02:11, Shawn Anastasio wrote:
> Communication with firmware boot services on PowerNV requires parsing
> the fdt blob passed by the bootloader in order to obtain the firmware
> entrypoint. Use Xen's libfdt to do this and store the information
> required for firmware calls, to be implemented in a future patch.
>
> The full xen/common build doesn't yet work, but libfdt and its xen/lib
> dependency can be made to build by defining a few stub headers.
>
> Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
Looks all plausible, so with the earlier constraint
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Just one nit:
> --- a/xen/arch/ppc/setup.c
> +++ b/xen/arch/ppc/setup.c
> @@ -18,8 +18,13 @@ void __init noreturn start_xen(unsigned long r3, unsigned
> long r4,
> }
> else
> {
> - /* kexec boot: Unimplemented */
> - __builtin_trap();
> + /*
> + * kexec boot protocol
> + *
> + * TODO: This currently assumes an OPAL/PowerNV system, but it's also
> + * possible to be kexec'd on an OF system.
> + */
> + boot_opal_init((void *) r3);
No blank please after a cast specifier. Can surely be taken care of
while committing.
Jan
|
