Re: [PATCH v4 02/13] xen/arm: Introduce 'choice' for memory system architecture

[Henry Wang <Henry.Wang@xxxxxxx>]

Hi Ayan,

> On Aug 7, 2023, at 21:17, Ayan Kumar Halder <ayankuma@xxxxxxx> wrote:
> 
> Hi Henry,
> 
> On 01/08/2023 04:44, Henry Wang wrote:
>> CAUTION: This message has originated from an External Source. Please use 
>> proper judgment and caution when opening attachments, clicking links, or 
>> responding to this email.
>> 
>> 
>> There are two types of memory system architectures available for
>> Arm-based systems, namely the Virtual Memory System Architecture (VMSA)
>> and the Protected Memory System Architecture (PMSA). According to
>> ARM DDI 0487G.a, A VMSA provides a Memory Management Unit (MMU) that
>> controls address translation, access permissions, and memory attribute
>> determination and checking, for memory accesses made by the PE. And
>> refer to ARM DDI 0600A.c, the PMSA supports a unified memory protection
>> scheme where an Memory Protection Unit (MPU) manages instruction and
>> data access. Currently, Xen only suuports VMSA.
>> 
>> As a preparation of the Xen MPU (PMSA) support. Introduce a Kconfig
>> choice under the "Architecture Features" menu for user to choose the
>> memory system architecture for the system. Since currently only VMSA
>> is supported, only add the bool CONFIG_HAS_MMU to keep consistent with
>> the default behavior. User can choose either VMSA or PMSA but not both
>> in the future after PMSA/MPU is supported in Xen.
>> 
>> Suggested-by: Julien Grall <jgrall@xxxxxxxxxx>
>> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
> 
> The patch looks good, but it does not cleanly apply
> 
> b4 mbox 20230801034419.2047541-3-Henry.Wang@xxxxxxx
> 
> git am ./20230801034419.2047541-3-Henry.Wang@xxxxxxxxxxx
> 
> Applying: xen/arm: Introduce 'choice' for memory system architecture
> error: xen/arch/arm/Kconfig: does not match index
> Patch failed at 0001 xen/arm: Introduce 'choice' for memory system 
> architecture

This is weird, so I tried to apply this patch (by clicking the mbox button on 
the top
right of [1]) on top of
65f0d6fc80 x86: Drop opt_pku entirely

and below is what I have:

$ git am 
~/v4-02-13-xen-arm-Introduce-choice-for-memory-system-architecture.patch
Applying: xen/arm: Introduce 'choice' for memory system architecture

I suspect recently there is some Kconfig changes, so could you please clarify 
your
base commit? Thanks!

[1] 
https://patchwork.kernel.org/project/xen-devel/patch/20230801034419.2047541-3-Henry.Wang@xxxxxxx/

Kind regards,
Henry

> 
> - Ayan