[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/5] mm: Factor out the pdx compression logic in ma/va converters
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 08:05:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g2Yzjge/p0tWN7wdJH/oMS1mkwIsQlhjyMxz148iZ2M=; b=TKppu9NmhXrFIP969QiRbsrBiFNqMSSLhUFPnTmmGmlrI/DqyR05CIfuBppyqgvHXXnGDdC8N1ry9cVJ01cZyJrS2mMfxaU27ynhswF51ZJmpIX/fdBJGgLr2IUMORBFo9xCWsLHCuljk7ToA8TsS8+OfCgQERtMKvp52YlBvKAEXmJzpsLOd7pd7O431Lsk4yEKMvF8rv16JhS48s6ejq/+VGArjlq9WqZnDvV7i/z0Azey61M90F3WJQ17mi1j+nAGWPP/941vphPa1GGIKT4KSR5P6w5t7G4pn/5U+gItwMZxwptPm3/6BuV5ITwQsXCu0Ixx9Da4Jn2a2YrZWA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HYjzD2nVc9oegIBKedZSUX3uTqvFys8bGzW/t2Gv6AQjoE64y267dSIxMjhlfoRXb7DB5ILSYKomTaWzxx2PVjRohtzzriKXjMHE5nHrgtT1OyFAtunbdKzUHfShE3wIrhshBShWOwl26U4XLcP+zhtTWKsO/Sggm5UPafM9LaqknJL3NeXjVby+7d3CD1uNHDjUWwy6FZZv7Z/Pu7n7opLMx9dNCHG8vwOzzL6PI58wvPG2x90qm19fsXFjMRJa/HWYEz7mnPuuALLEyKAHHA8KzEhTPrDwCeirAOBWy7POx3jo6A/soELLtLhyA3rzRPLCFqEqLVdeIhG4oogszA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 08 Aug 2023 06:05:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.08.2023 18:26, Alejandro Vallejo wrote:
> On Mon, Jul 31, 2023 at 05:15:19PM +0200, Jan Beulich wrote:
>> Especially since the names of the helper functions are longish,
>> I'm afraid I'm not fully convinced of the transformation.
> In what sense? If it's just naming style I'm happy to consider other names,
> but taking compression logic out of non-pdx code is essential to removing
> compiling it out.
I understand that, but my dislike for long names of functions doing
basic transformations remains. I'm afraid I have no good alternative
suggestion, though, and while it's been a long time, this may also
have been one reason why I didn't go with helpers back at the time.
Plus of course I remain unconvinced that compiling out really is the
better option compared to patching out, as was done by my series.
Jan
|
