[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] move __read_mostly to xen/cache.h
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 8 Aug 2023 11:18:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y48+mdA12KlhD2wOqIeA0SVsEUh5pXtbmmkGEanAYtI=; b=IpRRpYdDUrURu0848MF7qceY1xX3YEeRUH1fsM3PiJttVyd5OilME/VKyqyOpAcEQCltIOrPwUGJG/3KHDieKEI+zacXS+wBwkVXJEJhFGMVrdJC+fxnSCm1oytpzKaVg42aOR5UkqGbUDicQFHxVNMPLlf4cyF/uZhssIVgbnVAo0ZXhKZXupND1cDf2oT9jM4iqGdzEWeL0990cstuBl7PHXPvyl0pZ1MNJhNwiJ/4J7pXFWGGarfKmzfJgZL1x9XoVA+lcIgovIXKK7ONn7X4MprB1tl/Vw7gJ3fmpKAslMQ578O27OgrPdWMtczWqBdVdZtvORt7/eQd3WX1xw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A+PQxvJaK4YP062TEM/FXAJBZwmOaMlse9CxhpIbvVBiBA+PWXUnIV8yHk4bwsNHv0vL2iFe5VMn3shI2j37FI9KT4C4K3zTAqSOfCWH7K3kQtRM58qIlcCDUO4MQmgHxsg52P8TYQdq/SgpvmnujDnFsoDb6EQ5ZW+IY7E7J7ulOTI9PXSUgcUaiWu0ANdzxsSh8BZHSUC62Dw4fG6eggP5hx6oWWOfeFqcsl/s/wIGHTct8i9VIuYPdduHIEuCqjGyQ3mC1Plx5xjhZqTc7YFgqbRjBFtWEJ3Hb/pgtT1HEqBPlaWTf80kWwH2ulhRLEyJWZ5b7jcUSMP2J+SQMA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 08 Aug 2023 10:18:42 +0000
- Ironport-data: A9a23:ItPIy68vMaNyXtJ8KQWnDrUDLX+TJUtcMsCJ2f8bNWPcYEJGY0x3z 2cfX2CEPv7fZ2ehKoxzYYWyp0hV7JCAm9UxTlNoqXw8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ird7ks21BjOkGlA5AdmNagU5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklz9 fwZMjUcbCm7xLuxmo7iGvllhvs8eZyD0IM34hmMzBn/JNN/GdXvZvuP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWDilUpiNABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdtCS+Tiq68w6LGV7jVDJhcHUWKdmtnjoXWFeYJbe 1JTyiV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq19KqQrD60ETgYKykFfyBsZRAe/9DprYU3jxTOZtVuCqi4ipvyAz6Y6 y+OhDgzgfMUl8Fj/6+250zdijSg4J3AVBco5x7/V3igqAh+YeaNeYus7lTK6OdaG4yQRFKBo XssltCX6aYFCpTlvDeERuwWALiy5vGtKjTEnVl1Ep8u9jKg9mSie48W6zZ7THqFKe4BcD7tJ UPW5wVY4cYLOGPwNPcvJYWsF84t0K7sU8z/UezZZcZPZZ43cxKb+CZpZgib2GWFfFUQrJzT8 KyzKa6EZUv2w4w+pNZqb4/xCYMW+x0=
- Ironport-hdrordr: A9a23:0ixsUqAUFNOCj9TlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/08/2023 10:46 am, Jan Beulich wrote:
> There's no need for every arch to define its own identical copy. If down
> the road an arch needs to customize it, we can add #ifndef around the
> common #define.
>
> To be on the safe side build-breakage-wise, change a couple of #include
> <asm/cache.h> to the xen/ equivalent.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Could we find a better place to put this?
__read_mostly is just a section. It's relationship to the cache is only
microarchitectural, and is not the same kind of information as the rest
of cache.h
__ro_after_init is only here because __read_mostly is here, but has
absolutely nothing to do with caches whatsoever.
If we're cleaning them up, they ought to live elsewhere.
~Andre
|
