Re: [XEN PATCH v2 5/5] x86: refactor macros in 'xen-mca.h'

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 08/08/2023 13:08, Nicola Vetrini wrote:
> The macros defined 'xen/include/public/arch-x86/xen-mca.h' are revised
> to address the following concerns:
> - needless underscore prefixes for parameter names;
> - the variable 'i' in function 'mce_action' that is shadowed
>   by the local variable in the macro.
>
> Therefore, the refactoring aims to resolve present shadowing
> issues, which violate MISRA C:2012 Rule 5.3, and lessen the
> probability of future ones with some renames.
>
> No functional change.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> ---
> Changes in v2:
> - Added missing parentheses.
> - Clarified commit message.
> ---
Missing a
Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
from the other version, since nothing changed code-wise.
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)