[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 2/2] x86/setup: address MISRA C:2012 Rule 5.3 and 8.3
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 15:27:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p+1bKuDF35nMD+PYNOUpTAuzjL08nbd+vBgymUMmn3s=; b=df5IM0af2Vk9olW5jUUG7X67Q92m0BCNkWVxTIN3KqwrbkxzQnvS8S9JOYovF7rf9c9LC7nBhrccx9bb0P93YN7Sq6VyZ7WqNimBNFvY51UDvkWEAvJX56B0S/znsBPfDkTkUcLd2knTMsfk8ydCAReo0wdLaiUxwCYsDNIVBMpVMriaq8IIzNVGws0ZW3gpsEdCdUbMK7Mba/p+9bqxkeQ31SvrjkvC7hP7c5o0uUoH1ZJzJ0FWjc3P0+WgG77WX0eF6C2RlceI3jHCaDK0HDTekpGDsgwdR14F+BRC/zTZwDwjCHx5bfmzREo2uENtXiY/75a40gEOc1Op6UTu1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5IN8Ibj612KarmZ85cMngmIlSEj6XMzDxcKsmUJP0lu1HkmTzdloxrfRCCM04Au+Z4yMZcgGtEkoTUzGzRqixBOO//0lWgQTj/DrIQ3FC8yJ3JkT5hLX4Ifqj1HofKsw42Ykg5QTaaq6I1vicUnAQrLZITZz1KtCCJiV87dX5w7HSY5OQLcMlur2Odh8E9ac7Y5pK+9I1Jc+c2PO4V8SO9ChUYBQxV86l9bQuPV1Yj/1uovpxTRI3xIAnD57RgYrp9mAL/Q1YwpNPAmCoiqY2wKGPcNDXeIZW3PXzHh+83YqPou+m78KUUrOPhN51RdzXfPbgZwjRMKAe9E+jut3A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 08 Aug 2023 13:27:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.08.2023 14:22, Nicola Vetrini wrote:
> The parameters in the function declaration 'construct_dom0' violate
> Rule 8.3:
> "All declarations of an object or function shall use the same names
> and type qualifiers", but also cause shadowing inside the declaration
> scope with the variable "static struct file __initdata kernel;" in
> 'xen/common/efi/boot.c'. Renaming the parameters in the declaration
> resolves both issues
>
> The local variable 'mask' is removed because it shadows the homonymous
> variable defined in an outer scope. There's no change to the semantics since
> the last use of this variable is in the scope touched by this commit.
>
> No functional changes.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
|
