[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/3] tools/xl: reject bootloader=pygrub in case pygrub is disabled


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 8 Aug 2023 14:55:33 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 08 Aug 2023 13:55:47 +0000
  • Ironport-data: A9a23:OEqeLKCHj0zmNRVW/w/jw5YqxClBgxIJ4kV8jS/XYbTApG8q0DADy GdKUWDVP6qLM2DwKI9wPtzi/B4Cu5CBy4dnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbCRMsspvlDs15K6p4GNA7gRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw8eYwIHBi7 /MhAz0jNUCpo6Hr/7brc7w57igjBJGD0II3v3hhyXfSDOo8QICFSKLPjTNa9G5u3IYUR6+YP pdHL2M1N3wsYDUWUrsTIJs4gOevgGi5azBCoUiZjaE2/3LS3Ep6172F3N/9I4XaHJ4FwR3Iz o7A1zjIIggjbtiW8juU7Cq8g/CfnS3QWqtHQdVU8dY12QbOlwT/EiY+V1ShpuKiolWjQN8ZI EsRkgI+oK53+EG1Q93VWxyjvGXCrhMaQ8BXEeAx9EeK0KW8yxmdLngJSHhGctNOnMYuSCYjz FOhg9LjDjspu7qQIU9x7Z/N82n0Y3JMazZfO2ldF1BtD8TfTJ8bhRKIb8dPCqGMpdDbQmHa5 3PXkyxuvuBG5SIU7JmT8VfCijOqg5HGSA8p+wnaNl6YAhNFiJ2NPNLxtwWChRpUBMPAFwTa4 iBY8ySLxLpWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWWxC KMwkVkLjHO2AJdNRfEfXm5JI552pZUM7Py8PhwuUvJAY4JqaCiM9zx0aEib0gjFyRZ9yP1kY s3KLZb1XR727JiLKxLsHo8gPUIDnHhilQs/u7ikp/hY7VZuTCHMEupUWLd/Rus48LmFsG3oH yV3bqO3J+FkeLSmOEH/qNdDRW3m2FBnXfgaXeQLLL/cSuencUl9Y8LsLUQJJ9A0xvsIy7aSl px/M2cBoGfCabT8AV3iQhhehHnHB/6TcVpT0fQQAGuV
  • Ironport-hdrordr: A9a23:+NW3iKuuc/1AAo4GShoJOMRA7skDTNV00zEX/kB9WHVpm5qj5q eTdZMgpHzJYVcqOE3I9urqBEDtexnhHP1OgLX5X43MYOC8ghrNEGgK1+KL/9SHIUDDH4Vmu5 uIHZITNDVeZ2IK6/oTTGODYrQdKHjsytHMudvj
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Tue, Aug 08, 2023 at 03:22:19PM +0200, Juergen Gross wrote:
> In case Xen has been configured with "--disable-pygrub", don't accept
> the domain config option "bootloader=pygrub".
> 
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

I'm unsure about this patch, but I guess we kind of expect pygrub to be
built at the same time as `xl'. And it still allow to use "pygrub" if
one specify the full path to it. So,

Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.