[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 2/5] xen/delay: address MISRA C:2012 Rule 5.3.
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 15:56:10 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uz4px8UJT1vPWJRglAC0NI2xRKiOs91Y99XgwbTNFIE=; b=HWoBoKvA2+9M/Lm+qGBDMjNfsDF18deWjK4u2ybPdRz72LrgvSlOFat6TF0+ZZ95rO/fK6oLXVelDFGvfAr+ubqQqntBzH3mD2edEnavoDD1A2aWaH2CFyxqUl9xdrkU6TZoEsaLp8d6Rh9ZocQElkZfUrxSyphUoBFWTKONwdenKmuvOVD9v5IMXsTHQb5MAYaa4Xrq21dAueqUSwj5b/cQm4ZeyyY9/dDaX2mAdp21uQzWIbiGUrlxpY4ZYJuxqZg2YoX11zlkxLzoMZegQY/GOnf++kGQF1r6YnJzAcQxkxpt3EFPwhTQjHd6QfX0oZPgzJU9fg1/4vDFqGFTtA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D8lgDNbi+Q/dqs2X+Q+MjOGiHnI2+EOd3LCRYbaIAreCsgg3ClBWXG7UvBz4HM4oI07tax9cCPPoeKsJN+3LwLav9asELMh6sOMldteMammlbng0bMb8UdrBZcuKgmnfuYEGDz/GaeYXgyD8bCGNqiwx6RX3hebEnGaIgSR8F1ovHPYeKKUtxPt8tyUx8vU2HGDHsVSSjMUEkaTXk8Uckgw22OYZpvqjAgdbRVus3glgB43U36vN4wwzokaoE1kmgLcW7wXX3t82mAQ+s3haf2ENOLPDgL4XpoV72P69QUS7KfH92tikidkxpjiLIvg+wZCiBLCK8Y1WabH4n3lfyQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 08 Aug 2023 13:56:19 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.08.2023 13:08, Nicola Vetrini wrote:
> --- a/xen/include/xen/delay.h
> +++ b/xen/include/xen/delay.h
> @@ -4,7 +4,12 @@
> /* Copyright (C) 1993 Linus Torvalds */
>
> #include <asm/delay.h>
> -#define mdelay(n) (\
> - {unsigned long msec=(n); while (msec--) udelay(1000);})
> +
> +static inline void mdelay(unsigned long n)
> +{
> + unsigned long msec=n;
> + while ( msec-- )
> + udelay(1000);
> +}
Nit: Style (blanks around = and blank line between declaration and
statement). If need be I guess this again can be taken care of while
committing. With the adjustments
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
