[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 3/5] x86/include: address MISRA C:2012 Rule 5.3.
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 16:01:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=baBWFeRjOBkdXC/voNhdSJw5wzxdGRLHNp0RW+pSYAU=; b=cIUgtHum3ktYsG489zG7/k6UeJ+idr88GDeYwEX5wnfTzTHf2ZuEqmPYNU1l16w/GDUyknbzWyw+lzqjBlGDzU7VkBsLzVyBEmWQZpaPtcIWB6Mc13x+c91Ybuj52bk63vle+WtY/FnSdieceDBV50s4jOHzB0mlRsZv0f3qL0abgMcQX0gePuUERD3x96WYmLPWy1a5uqB9XGRAO/dkHmAiZBpfY7PaMMgItri3SPe3Rs6da+IF8SrwFBtWj4A9YIdVQeLGwb/wAQpONCGfeSlfrmin//hME3vJOKCcJAhR0eGYZ0JBImbMO1MbzbP/tRkodXaVHCixJVj+oVD9aQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=odPYHy13W948CIc0WTEbnj/sRPp0MXPEkF0vY5pbdc9GBV2qClcKsleR/dclcCPhV6Xt+NGai+PucCg5U5c1WgQztmJyDzpJTzXDhr1NwXrQOuPwRM2IdeQPM4J4rkoxfCWSOceRrKXdZgUUHQdzyX2r5Szheo30HxwrN0+FS06BqwblFelKgr2zz1cT4ZSSWTwMPZo4ezJ9UFLla46o7372kiaMRK+Xkof155eAPxl7Fi4yCfVBVAYTgXegf1Sosq/6/MrHOVeosFPTxBLPfPPbWJXGyJ9z5Kj1sULp2ND0XGHpIXfSexzlzWKrPFChGKj0AqjY0V+r5nXOQnumKg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 08 Aug 2023 14:01:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.08.2023 13:08, Nicola Vetrini wrote:
> Variable 'mpc_default_type' in 'xen/arch/x86/include/asm/mpspec.h'
> has no uses and causes shadowing with function parameter names
> in 'mpparse.c'. Therefore, it is removed.
Personally I'd again wish this could be expressed more precisely than
just "variable". What you're removing is a declaration which has no
definition. So aiui shadowing is only one of the concerns Misra would
have here; the lack of a definition would be another.
> No functional changes.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
