[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mem-sharing: move (x86) / drop (Arm) arch_dump_shared_mem_info()
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 8 Aug 2023 15:08:39 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LR531HV0oY4lV7VgzQe4AkX5MZLRVgBb2FpikOdOUg8=; b=HMwsirfTTKamCsO84s+DfEuq03sgHCNuDgBtlBN1Y+HOw9FiLuy0+6bmfmrLgjQmBd83IHKKLlON5JFd4NmRSQBMUCt0IzKxa0Z6yfgIFEw0nuc6HllKVqn3rWQhZ+MoBF4rznq+u5LSUk2M/ry16BSsNjnG7MnAGU14UUedArNzJeoksODcR2M9yBIc3eBI2XeT05izUxjjo6McrDK3RRh9P2r9h7LK5iC6K8WoqmXEGqju57EjU0A5EZEJhFkbhQ4JkXvd+lg/ANhZegI3WjBb/EhvlrRj+dNJvvQFrjqMXD7+5LZj+ceZntysU34KWlaUHwnG1ZUZADqK34C5Dw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hAHcJ+JOVMUeQ/3Z1pG7lqAVX6cO/4ui6+MuAP4rhiYCOECz9B9zDWgalouPcnVUaw+4ESmNwquMWSyDBak3yjcX6iyQ870BVssGgDVINIzcv1V7GtP2Tuv6wHa4R1lj7nqoAQbjtNPNzfW3E3gInUZlAl1QneeZdxaGv8SvdHREAXb5KYzVnN7XLvcOyhIaRHEI4aoeG1hHpwQ5ClhuCScg+TnmNkv0Z7FYEwGBhCGcxpK7jiddU1ahLvFhEX8D3ukdVO4n/ECb3GT/EcVqsmXbmaSioYcN0uOpNVWyMFyUT3R+Lm2XYc/0fql6QZ9jT7k0U8d7Y8j81LtQVdRO0g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- Delivery-date: Tue, 08 Aug 2023 15:10:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZyfBJrIpFu/4jlkOaspAEusf4b6/ggH4A
- Thread-topic: [PATCH] mem-sharing: move (x86) / drop (Arm) arch_dump_shared_mem_info()
> On 8 Aug 2023, at 13:02, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> When !MEM_SHARING no useful output is produced. Move the function into
> mm/mem_sharing.c while conditionalizing the call to it, thus allowing to
> drop it altogether from Arm (and eliminating the need to introduce stubs
> on PPC and RISC-V).
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> I wasn't really sure whether introducing a stub in xen/mm.h would be any
> better than adding the (further) #ifdef to dump_domains().
>
> We could go further and also eliminate the need for the stub variants
> of mem_sharing_get_nr_{shared,saved}_mfns() by moving the
> XENMEM_get_sharing_{shared,freed}_pages cases in
> {,compat_}arch_memory_op() into the already existing #ifdef-s there.
> Returning an error for those sub-ops may be slightly more appropriate
> than returning 0 when !MEM_SHARING.
>
> --- a/xen/arch/arm/mm.c
> +++ b/xen/arch/arm/mm.c
> @@ -1297,10 +1297,6 @@ void free_init_memory(void)
> printk("Freed %ldkB init memory.\n", (long)(__init_end-__init_begin)>>10);
> }
>
> -void arch_dump_shared_mem_info(void)
> -{
> -}
> -
Hi Jan,
For the arm part:
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx> #arm
|
