Re: [PATCH 4/9] xen/ppc: Implement bitops.h

[Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>]

On 8/8/23 3:36 AM, Jan Beulich wrote:
> On 03.08.2023 01:03, Shawn Anastasio wrote:
>> Implement bitops.h, based on Linux's implementation as of commit
>> 5321d1b1afb9a17302c6cec79f0cbf823eb0d3fc
> 
> But with PPC32 bits dropped afaics, and with leading hard tabs replaced
> by four spaces - which in turn appears to yield some unhelpful placement
> of line-continuing backslashes. And with some
> asm-generic/bitops/builtin-*.h expanded. Please mention all adjustments
> you made, to allow for some future importing of updates to go as
> smoothly as possible.

Yes, that is all correct. Additionally, the code was adapted to use
32-bit words for bitmap entries like the rest of Xen's architectures do
instead of the 64-bit longs used by the Linux implementation. I provided
the reference to the Linux commit for completeness' sake, but to be
clear, my changes have caused it to diverge enough where I wouldn't
expect direct imports from Linux to be (conveniently) possible.

I'll clarify this in the commit message and also fix the macro
line-continuing backslash spacing.

> Jan

Thanks,
Shawn