[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 5/6] capabilities: add dom0 cpu faulting disable
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 9 Aug 2023 08:53:55 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p1cFDW0cxg+T7WdovLB28zEgLcbGf1NgCosVjYcqQDk=; b=KsVAcxBSiLqmIPJuxxsjnKVqCKbAGT7nUc5RShFYYkDNUWva6H17IptvBErgoTM9kyZ3Od/4qn4nlQuRruNgE9IMvw0FUNGIy2wZpttXs7DM3BlXY5Bp9DuYiIsSQmYVxqGDKIAkBJm52yagbP6NhK692FzNd3KGej0G722UaXYgvocvbvxhHVThcYfj/dOGjOBo4X4FvSlVv50vAmYMExKrfnYsj5ObDCXtV13iOcrfjGbPXhps/qQFdLQtXtP3otaxXygWDIE6mLdF6a3vttpr3j+AQo6aeAXNzZuhqDAb6GQuwTFmBKv2XmGKvgK95Te/zBHvmW1yokjySSxPKQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EAjVfmc2NPp8OhBdXYg+YrtvZVXDXUpiNqQU7jNZ0VTUt0O6bmOWWs2qMA/FOI57yUCHy6difOPeqIuPyXtdMWSk5bNTwajLCKL68t9ZAHUK35Mj4zr9ihPRKkmOAlOE0QDsrXtB3k3Epo25Vjy5rlTluhEnl56M6KRS+9jnNb2CqBFfb2ImU+S+vFb5kcdlEKfuPZ5lL/7UGwYglE0ddB1IggMrBl7svrZJizByD25eYuY8TcDkNJBat5EJysy9k+KSjdMTtak76hGMyzpsP8GJKZRd1bTLS5ixE5sorcemd65NYz9WwxqzuzbYTUFgYtZ9nu/cpEiW9RB6GFcnng==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 09 Aug 2023 06:54:03 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.08.2023 01:59, Daniel P. Smith wrote:
> On 8/8/23 11:30, Jan Beulich wrote:
>> On 01.08.2023 22:20, Daniel P. Smith wrote:
>>> --- a/xen/arch/x86/setup.c
>>> +++ b/xen/arch/x86/setup.c
>>> @@ -907,6 +907,10 @@ static struct domain *__init create_dom0(const
>>> module_t *image,
>>>
>>> d->role |= ROLE_UNBOUNDED_DOMAIN;
>>>
>>> + if ( !opt_dom0_cpuid_faulting &&
>>> + !domain_set_cap(d, CAP_DISABLE_CPU_FAULT) )
>>> + printk(XENLOG_WARNING "failed to set CPU faulting on Dom %pd\n",
>>> d);
>>
>> No "Dom" please when you use %pd. Also I don't think you mean "set". Plus
>> we commonly use "%pd: xyz failed\n".
>
> Ack on the "Dom" removal and "%pd:".
>
> As for set, it failed to set the capability on the domain. You could say
> enable but that is nothing more than synonyms, not changing the meaning
> of the statement.
But you don't say "capability" in the message. That's what is being set.
But what you do instead is disable CPUID faulting. In fact I wonder
whether expressing that as a capability actually makes sense. To me a
capability is something a domain may make use of, but doesn't have to.
That's not the case here: CPUID faulting is either active for a domain,
or it is not.
Jan
|
