[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 7/8] x86/i8259: address MISRA C:2012 Rule 8.4
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 9 Aug 2023 16:22:33 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jgM5Mt6ivU6EM9j1oL3VKfq3p/kvqxSG+6Cr5YWWDJk=; b=XE99X53Np0lt/vCvvvbCT2VElFi4XSnyJS1cLrJiE0z7emc4Z0j59ULYvtNuujstKu5+PO5Cp/NScc4RqfjmGvodnri/bV9LtXb5vm8liquypSwtewBIqlFMyLLnZ1dtcXzdekWOk2SsRbig1aAHKjvNy6gyEUCwxBZlR6XjyGYLE+j4FvV2YL8rANmoyE4XG4MWY7NRDXE16vdQf0e00WQncbpUK22wDGy1OMIYwmlNwak3ePpP2oveVdW47MY5tyExgFxNSDExLNtKUqdxGtlhzUMDO5SKyDih7z00Yvu9ub21YEVMOUIo+6TFZCJYAAKOWHgWlD0zdcH25+4INw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q5QLnH2jERA6yEMwuOCkT514wN5yq2V+N0N3v9/RFjnoHoPQk/0h59u+gU5f2nraOTFxa4b5QKIyYfQh9yNvIj8ToMuYxw6S26t/21Wf+p/FfKSrDQKM7VYWnbxMOkaTK8fZ35mweb7XZ89ysnv/A+wsNIIgQ1wFJdRJwauDxU+IwthYi2/GraKeMocCZWGck/HbUhf3d1uj9ctOJ9MSYCiC/hHPdXgVsVGprOy9Q6eK3N9GKRSZUvqakQRrDfr0dabUcWHdOY0xjxc6hBxJ/7Ec+bVDwtYcpKFxNgUizHy03H35gR+HwatoFO4BO1RYhyrgfODYKWftiT2wqzJ+qQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 09 Aug 2023 14:22:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.08.2023 16:17, Nicola Vetrini wrote:
> On 09/08/2023 14:52, Jan Beulich wrote:
>> On 09.08.2023 13:02, Nicola Vetrini wrote:
>>> The additional header file makes the declaration for the function
>>> 'init_IRQ', defined in this file visible, thereby resolving the
>>> violation of Rule 8.4.
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>>> ---
>>> xen/arch/x86/i8259.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c
>>> index 6b35be10f0..9b02a3a0ae 100644
>>> --- a/xen/arch/x86/i8259.c
>>> +++ b/xen/arch/x86/i8259.c
>>> @@ -19,6 +19,7 @@
>>> #include <xen/delay.h>
>>> #include <asm/apic.h>
>>> #include <asm/asm_defns.h>
>>> +#include <asm/setup.h>
>>> #include <io_ports.h>
>>> #include <irq_vectors.h>
>>
>> A patch adding this #include has been pending for almost 3 months:
>> https://lists.xen.org/archives/html/xen-devel/2023-05/msg00896.html
>
> So do you prefer going forward with that patch or this one (mentioning
> it
> in the additional commit context of course)?
I would prefer using the much older patch, but of course this requires
someone providing R-b or A-b.
Jan
|
