[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 03/13] xen/arm64: prepare for moving MMU related code from head.S
- To: Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 10 Aug 2023 07:03:36 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cvrWNyjbDpTmZnf0vMth/aapfAQuIjJ3bnmuNzS6s7s=; b=CNEHI2ttBmIJW1tnpL11OeO33bdUhSisF4HMJSkaRlmO6UwHfrPCIyAvF0SbPk/bndVDcJLhzGPwcea5U/3JaS2eMjgzBlJliqoOlP6L2XHcrzaBLj/5oosRdwhmUD+/2Zftswe0C3SCB9CKPLW9SX79fGztcIDoc4kIp+Gv/tg6aQpcYdPAY4eT69yRGvcmxqKRbDUollu1IkMCUwyP/FjnE3rUcLpRM+1Dq8PdCJwJeQI5pVHntyNitOB6G8rOX6BMFGhhl0B3WMSRu5xJwjiCFNmm+s+a9Nv65CXs4olajnpWlQrv/7rq3aVA6HN5UyojDVI7aYgnoWEqNDk5ow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WFEoPCioU7bzNWFE7cD+VB14kUd4zNXkj3+3nyfH/Qjx2QZW26HNcCKbnp1q2KmsYM3MZCz/fMthbaOCYF1FgaDj5VVdKdHaNsVjIHP0Qjuof3CpCn55PXLDcqz9HqeXqObhvmKmk6LCMVzQWjfvREJ6E8T+7Gen8U7C02giKfASKKdiiqhO808JS/f2D9258YxHBfPpQDgKK0AzmgWtI7cj4qAhpwQMKk+p1JS+w9VMOuyZ70N/ogIvCi4j8NU4J+p+t2pjEckYa1JxIM3tt9yMjENHJrDt9d2vdTTAM4d9iIqfsAkfYmck5660lkL+JoSF0mDmILxo9oZdgMClYg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>
- Delivery-date: Thu, 10 Aug 2023 07:04:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZxCqG6oYnCgdHhkmb5cGeqRWv6K/h7S6AgAE7/YA=
- Thread-topic: [PATCH v4 03/13] xen/arm64: prepare for moving MMU related code from head.S
Hi Julien,
> On Aug 9, 2023, at 20:12, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Henry,
>
> On 01/08/2023 04:44, Henry Wang wrote:
>> From: Wei Chen <wei.chen@xxxxxxx>
>> We want to reuse head.S for MPU systems, but there are some
>> code are implemented for MMU systems only. We will move such
>> code to another MMU specific file. But before that we will
>> do some indentations fix in this patch to make them be easier
>> for reviewing:
>> 1. Fix the indentations and incorrect style of code comments.
>> 2. Fix the indentations for .text.header section.
>> 3. Rename puts() to asm_puts() for global export
>> Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
>> Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
>> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> With one remark below:
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks! I have taken this tag with...
>
>>
>> -/* Print early debug messages.
>> +/*
>> + * Print early debug messages.
>> + * Note: This function is only supposed to be called from assembly.
>
> I realize the wording is just a copy of what I wrote earlier on. But I would
> use 'must' as this is a stronger than 'is supposed to'.
…this fixed locally.
>
> This can be dealt on commit if there is nothing else to change.
Either way works for me, maybe you can add this patch to your queue
for your next round of committing. If I don’t see this patch being committed
by the time when I send v5, I will keep this patch in the v5 series and send
it with your Reviewed-by tag.
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
