[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/9] xen/ppc: Define minimal stub headers required for full build
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 10 Aug 2023 10:04:01 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PUc532/w6szC+JEuVUjiEnOWawjebcTbX3zIHF8+2PE=; b=R9SnGjegpLubivQjrK6VAewWlveoE2tbSRMkUeMYjgR+ObTgpciVBwDmg1fvwLskFVnpGATZD1tB3gnXmi9f2gR1pAe3Y8SluHBkz4fFMCm/f+ge5CZqFVGSTHgbgtHOMAt645rj1r3xNiMLbitOk5TzDdycAIi/gUJPks7ueSgrZ5gkWo19V7wZBytNzlZLwjRII4dxKj5dYhPbYw6/G9chS+j08lR5JUpyGgdvRH1d0MPPoK+eXy5JAB/4K4ym1JL1N82QBJgGWjKnrkDgrVoeRra1KnEAPqTO10IjWyWbKNxJFPaCxZaBZOb3VY3gAym9vZdSAr1XWMc0pbkvSQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxFjPyZQG+9NrIFwpo5Y16j5VZO9FGA1CvdpfUhi6NkRhsE+1PEiDRTSBf5BaqGNcZET9Yaf0Z7cE5WMMWxb5BglwbuZgCjo4FT6yTMm5OhgU153peB2YXAm81U7SMKmvFa98bv2J/URn4X3Bl2HvIWA5xfbwv6o80v3vIdTIiKFepSjjZa1Fu2teEyQWLyTm78yXGk+/ylhiU7HH+ZPh5ANlit07OwOHk7U5+OEVXAyOimNqBN6NizoAr2U9Llu1Z5WWV0CvKQ5phX03KdjesQkZTfwfvhdIsNdpEOjTzBzlq11QL1v3h+ha+twphcMp1J0Y6+1Dv1Op+HBiMbC+Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 10 Aug 2023 08:04:24 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.08.2023 20:41, Shawn Anastasio wrote:
> On 8/8/23 4:12 AM, Jan Beulich wrote:
>> On 03.08.2023 01:03, Shawn Anastasio wrote:
>>> @@ -15,4 +16,10 @@
>>>
>>> #define BUG_FN_REG r0
>>>
>>> +#define BUG() do { \
>>> + die(); \
>>> +} while (0)
>>
>> This looks like it's temporary. I think any construct that later needs
>> updating wants marking in some common way (such that it's easy to grep
>> for items left to be dealt with; you have such a comment in e.g.
>> asm/event.h). Of course if an entire header consists of _only_ stubs,
>> perhaps a single such comment would suffice.
>
> Yes, agreed that this macro deserves a TODO comment.
>
> As for the rest of the stub functions that this patch implements, are
> you suggesting that each file with stubs should contain a similar
> comment?
Well, each one needs to be (and remain) easily identifiable.
> Another alternative that I thought of would be to define a
> BUG_UNIMPLEMENTED() macro or similar and call that inside of all the
> stub functions.
I like this. Or maybe BUG_ON("unimplemented") could also be an option; not
sure though if the compiler wouldn't complain about the resulting
if ( unlikely("unimplemented") ).
Jan
|
