[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2 1/7] xen/memory: make 'ioreq_server_max_frames' static


  • To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 10 Aug 2023 11:00:30 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=40VPJiKTJTqvfzxYnOBbm5trwHZ4BPF5zYlofLlqvnI=; b=c+8Gg3/diZ3B40RQOw90m+OevvRmLMCUbCfnugVyT39ixBEBHO2ZBdSGWShNVPyrtJXopawNsiHk/64tuMOoG/fMb4JkA5cbpZ7eKF8APv7PMZsaJVTpEwRxcP5JxYd5DrH+6Bk/gZIERxYTr5RbyrJWpv2kLf0necyDkfTxKZBHp9vhcPQxjzdnV8cCMCRkLxrUKMHrJwMGudVkLxFqydRqadI796PC00K16PQE44obmYt9GX9RksHa5kgK5nD4D2H4vfIFLv55sdvyGikTZBm9IW84VMnEtxa4VicK82Z7i/6y66+7RBCEE21fFkBgT8JdemtNH3ooPHJfPzeuZQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LbHTOcpe8LJ1wO6GjPhhLHQs6iQmVfhvmIHHFum85MyMYpIRdaYAEhavL5yxNEpqbrCdxWjFzGobS5/bBud6a+cptbWG4bcVkKo+YEIMPK23A9K2goOko06Tr8r+VLJS/7tHHJg0BMOArofj2PZUIkt7HKUb4y+g1Eg4kfLU7rFZMFvu0RKV74tjuiZwTlhPoZzoCv3QXF4YUbmprGtayf5OxxMOpuQQ6gTr72j2c/ctLWAU12S6a/f8ML4j6nFwEHMFhDgsuP8d6zZnzin7jbKPZl+Uu/06YDbpgZwP/LDeNtiex7rowhgv5xCA2pksA/zVtHDj8vZ6qp52wr6ydQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 10 Aug 2023 09:00:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 10.08.2023 10:39, Nicola Vetrini wrote:
> The function 'ioreq_server_max_frames' can be defined static,
> as its only uses are within the same file. This in turn avoids
> violating Rule 8.4 because no declaration is present.

Here and presumably in subsequent patches (I only looked at patch 2
for now) you're now missing the word Misra (ahead of Rule). I'm
happy for that to be added while committing.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.