Re: [XEN PATCH] xen/arm: traps: remove unused function 'dump_guest_s1_walk'

[Julien Grall <julien@xxxxxxx>]

Hi,

On 10/08/2023 10:29, Nicola Vetrini wrote:
> The function in question has no callers and its removal has already
> been proposed (and acked) as part of this larger series [1].
This is useful information after for the reviewer to know it was already 
acked, but it is not really past commit. So I would move it after ---.
> There have been further bugfixes to that function [2], but they do not add
> any caller, hence it can be removed.
If you want to mention bugfixes, then it is best to refer to a commit 
rather than the e-mail thread.
> [1] 
> https://lore.kernel.org/xen-devel/1395766541-23979-27-git-send-email-julien.grall@xxxxxxxxxx/
> [2] https://lore.kernel.org/xen-devel/20160720161017.4508-1-jtd@xxxxxxxxxx/
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> Suggested-by: Julien Grall <julien.grall@xxxxxxxxxx>
Aside the e-mail address, you want to order tag in chronogical order. 
This was suggested by me then you wrote the patch. So it Suggested-by 
should be first.
Other than that, I would like Bertrand/Stefano to confirm if they are Ok 
with the removal.
Cheers,

--
Julien Grall