Re: [PATCH 1/2] tools/libs: light: Remove the variable 'domainid' do_pci_remove()

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Wed, Aug 9, 2023 at 6:34 AM Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> The function do_pci_remove() has two local variables 'domid' and
> 'domainid' containing the same value.
>
> Looking at the history, until 2cf3b50dcd8b ("libxl_pci: Use
> libxl__ao_device with pci_remove") the two variables may have
> different value when using a stubdomain.
>
> As this is not the case now, remove 'domainid'. This will reduce
> the confusion between the two variables.
>
> Note that there are other places in libxl_pci.c which are using
> the two confusing names within the same function. They are left
> unchanged for now.
>
> No functional changes intented.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>