[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] xen/arm: Fix initrd placeholders generation in make_chosen_node()



On Thu, 10 Aug 2023, Luca Fancellu wrote:
> > On 10 Aug 2023, at 12:25, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> > 
> > When booting a dom0less domU without initial ramdisk, it was observed
> > that Xen still creates empty linux,initrd-{start,end} properties under
> > /chosen node. This is because in make_chosen_node(), generation of initrd
> > placeholders (later on filled with the real values) is protected with
> > a check for presence of kernel bootmodule (always present) instead of
> > initrd bootmodule. Fix it along with renaming the variable from "mod" to
> > "initrd" to prevent similar mistakes in the future.
> > 
> > Fixes: 48f4bf6bdeb4 ("arm/acpi: Create min DT stub for Dom0")
> > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> 
> Hi Michal, good catch!
> 
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.