Re: [PATCH v7 2/6] xen/riscv: introduce dummy <asm/bug.h>

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Mon, 2023-08-07 at 11:01 +0200, Jan Beulich wrote:
> On 03.08.2023 14:05, Oleksii Kurochko wrote:
> > <xen/lib.h> will be used in the patch "xen/riscv: introduce
> > decode_cause() stuff" and requires <asm/bug.h>
> 
> While as it stands the description is accurate, I don't think that
> later
> patch has a need to include xen/lib.h anymore. xen/macros.h will do,
> I
> think.
It looks like xen/lib.h should be still included as the code in traps.c
uses printk().

> 
> Also please don't write descriptions in terms of "patches" or more
> generally future "commits". Their titles may change, they may
> disappear
> altogether, etc. Finding such a description later will end up
> confusing.
> 

~ Oleksii