[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h


  • To: Julien Grall <julien@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Fri, 11 Aug 2023 13:40:39 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KQfkcMShEh69JqDG4f+QFUhttAHBQxbmuASOiHoiTqY=; b=Fp0hbRSx8LORZgVCgBw5AFFwwmt5Fk041JiskCkSTWAVqizPlyGLKcFsCgRkZJwuwSCeESJmdqd8krvN1kbIlDDTwYk+q8b+QDGltakGdSQcM93Rt4L0VxsZkvQc3Xq4qHMw26L5/0EL63ExmcZwoPbOKz7xr4+O12e/nH3oZFjwdHY5ZunZ1CrPsE1gulz8WqQoD70h8oXUs7Iw8R0inYL3D3MftZPb0efGzv5mWY4D6gzCFYer3vonH1Ni+G2z2CRuKNXxBgJolCL8D9XErZynHYmkuec8yvOjr6Qm+1XQcvEGMK121PG9tmrr8dKLFu/5toZLES/ZYIqYYl7WCw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fzMvbIlWFKobRRwNlTG7iDmURJ1lrxNm9RwVnO8CMliITZuwHrGesU1jsR0LxVgMsX2QgdtaWtNfYcqptOnHxZSFCxFOCW0eFvxq1eTWYRaNAZmMcOBNTXjbRagr/zn7r7nNZrOQu1QXlwabs92q33vgLcfrYqU+6o1FyUU2A9AT/nC4CU1J0Gig/Cp8eHqO3cdqY+ilek+qol2uYWOlqJpbn4DHpZ9PepkLIJUuZV2jXAzWu8K+GmAyc8Qu8FgwlvmIXwUuvdEHl4j2EHo0tsw6LNjJZTOy2mpDSBzjc2YNY1gfCJ6ay8XQiG9oSu5f8DwkHfkVSgwr6Zw5A3hBuA==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Fri, 11 Aug 2023 13:41:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHZyc51AtDCvMz7Yk+h8v6wea9TNK/lEvIAgAAMOAA=
  • Thread-topic: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h


> On 11 Aug 2023, at 13:56, Julien Grall <julien@xxxxxxx> wrote:
> 
> Hi Luca,
> 
> On 08/08/2023 09:00, Luca Fancellu wrote:
>> Add asm/domain.h that is defining the type 'enum domain_type', it
>> is needed on arm64 build where this type is used for a member of
>> the structure kernel_info.
> 
> I read "needed" as in it Xen build is broken. But AFAIK, this is more a 
> latent issue if someone else want to include the header. Is that correct?

Yes correct

> 
> If so, how about:
> 
> The 'enum domain_type' is defined by 'asm/domain.h' which is not included 
> (directly or indirectly) by 'asm/kernel.h'.
> 
> This currently doesn't break the compilation because asm/domain.h will 
> included by the user of 'kernel.h'. But it would be better to avoid relying 
> on it. So add the include in 'asm/domain.h'.

Yeah much better, should I push a v2?

> 
>> Fixes: 66e994a5e74f ("xen: arm64: add guest type to domain field.")
> 
> While we aim to have header self-contained, this has never been a guarantee 
> in Xen. So I would argue this is not a fix in the sense it someone would want 
> to ingest it in there tree.

Ok I see, I thought it could be linked to the issue about sorting headers that 
led to build breakage, but I’ve
not investigated further so I would be ok to drop the Fixes:

> 
> Cheers,
> 
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>> ---
>>  xen/arch/arm/include/asm/kernel.h | 1 +
>>  1 file changed, 1 insertion(+)
>> diff --git a/xen/arch/arm/include/asm/kernel.h 
>> b/xen/arch/arm/include/asm/kernel.h
>> index 4617cdc83bac..0a23e86c2d37 100644
>> --- a/xen/arch/arm/include/asm/kernel.h
>> +++ b/xen/arch/arm/include/asm/kernel.h
>> @@ -7,6 +7,7 @@
>>  #define __ARCH_ARM_KERNEL_H__
>>    #include <xen/device_tree.h>
>> +#include <asm/domain.h>
>>  #include <asm/setup.h>
>>    /*
> 
> -- 
> Julien Grall


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.