[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5] xen/arm: Move static memory build code in separate modules
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Fri, 11 Aug 2023 21:57:10 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bEGS0wRdx8UI0U7Kbc3vxJthrwcG88bohMK6eHHTDQo=; b=nDOyTkzyhi/gGiN7+aURlPlHH6BQ5iUjEvCjUH24HkItP9GJGI4O4svUgASukdscx3DoUEQ6tZteYsstrganwj9yiL2dBkGlJtSHFs2S1G3GuNGacNWzoi2MBw5U3VvX5pHjXONRZOCdbQ8q86c40R7a1hzLbDM+JBpZx8m52okF6wKld/WJKGRYOywlhZT1gr+gt0oBMtn+J5wJfkmKx4uL37sUBVEdSvNL9l6pcfOVPxM9sBnGSb9FPU3cPunpbzbGng8eQxyd0Cdxpoh5xkWYe/kjVOGH9nMy9LJwaJAy07cmvyuygQwpw/sVEGknPhugkoqzUh7ngzsyWMTFxQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i/CW5TIzt0KP7bR6Y4VOeBd1IYJcF99FN1TQfcYbgYWhI1/oPwaTh+CR0VIBQTX20aH6U90LyCC6Ej/FnnldHaEdzeOEQxEEpwXkdlSdcONRIQNKfNQhYhN6xJOpowRxAxgY4UnBi1oez3ekyKqjWhh8BVoora0Xh+ETaopnrO/9mrkpvhYfhxJixccnc/LWFEW553j7qI4rSETG/LjovJruzu01Lno5XmCsK+Jxq3jz1pdUsGDBThMVqhx2XPpbxmDGomsu4XNLIhDuyRDwVF4POicmK0w3Tv89wxZ8GRcAGMzU+S4OzuE9GdI9WhqC9LS5U4oLHLYqDq00UFT9cg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 11 Aug 2023 21:57:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZyc55L9ICjabsSUqgCKAf+BkgTa/la64AgAA+NwA=
- Thread-topic: [PATCH 4/5] xen/arm: Move static memory build code in separate modules
Hi Julien,
> On 11 Aug 2023, at 19:14, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Luca,
>
> On IRC, you suggest to skip the review for the patches moving out some code.
> However, I still have one remark.
>
> On 08/08/2023 09:00, Luca Fancellu wrote:
>> Move static memory and static shared memory code in separate modules
>> so that they are included only when the corresponding feature is
>> enabled, doing that we modularise the features and we remove some
>> ifdefs from the code to improve readability.
>> Move process_shm_node function from bootfdt module and make it
>> externally visible.
>> The visibility of the functions allocate_static_memory and
>> assign_static_memory_11 is changed during the move from the
>> dom0less-build module to the static-memory module, now they are
>> externally visible.
>> A static inline helper called process_shm_chosen is introduced, it
>> will call the process_shm function for the '/chosen' node, and will
>> be used by the funciton construct_dom0 instead of using directly
>> process_shm, allowing some #ifdef to be removed.
>> No functional changes are intended.
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>> ---
>> xen/arch/arm/Makefile | 2 +
>> xen/arch/arm/bootfdt.c | 161 +-----
>> xen/arch/arm/dom0less-build.c | 646 +---------------------
>
> This file was created in the previous patch but now you are moving out the
> code again. Please try to move the code only once within the series to ease
> the review.
Sure, in the next push I will do the moving to different modules in one patch.
>
> Cheers,
>
> --
> Julien Grall
|
