[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 1/6] x86/hpet: make variable 'per_cpu__cpu_bc_channel' static


  • To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 14 Aug 2023 09:34:52 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Z6P//UiTBhtwDUnc5TffLPCjQMKeAqWHF8qvDO3eTg=; b=k73ukvwAJvU2FXtC3/fIlFwdQ7dDbagh4ujs/77TBTxo6efnKlsYh/r9KbscpM90radOO5pW8+wuj3iZna+TDY/ydyHYlKRC81xKaOkzRtDHfOxfQc8JCW7TOu6CVERghZF3xFOMLlVpH98RI6NxC3bZY0Js1kmTp6FLPDDd3vrd8whxkkmm1H62IDhbLQQ2M2Q9gv5uckozsRKMOtH2i85TNu65zGV8GuG4BC9VC6+4QmkWhGCAGG9b9DpFQBaagm5qGmTbPGnwStSJuih7qac6PCH/VlDMDsLvS309qwk6epR4iBBkewaTE2V8Cko1D7FWrejGwDjPUG+ZOow8jQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFk7TZrZLGswX4kw/90dKwzHlcn3LZ0ZYe58sCfM5wQCeEQ4CciILMS+479d/+a0mBzCtu1x6Autmm/xOnbrb+RqE3M1W0hKvbQAifbNYC5gvInl6Lz1TYNnLuKi1S9yOjkb9L+GqMtYCzqWPrsQxXuHTGMKrZVD5+cmKGR1yvmel9fQ0XwLSQ4PyKyjGFy0KDvVC2PLSczUNVoEFBLvsUFTN9+/vvriSxx0CibWVacEBtloGCf75O/no2eHn7jQyPK7Nr5vfTOGX8dYXRyQHBwWLXiWFpoeDqHQ3+IbaLpv6vzgo/x7Dg2fyjvzY/xpjQYWHx+ZjPLtJkYekGJkwA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Mon, 14 Aug 2023 07:34:56 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.08.2023 00:54, Stefano Stabellini wrote:
> On Fri, 11 Aug 2023, Nicola Vetrini wrote:
>> The variable is only ever used inside the file where it's
>> defined, therefore it can have static storage. This also
>> resolves a violation of MISRA C:2012 Rule 8.4 due to the absence
>> of a declaration prior to the definition.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>> Fixes: 3ba523ff957c ("CPUIDLE: enable MSI capable HPET for timer broadcast")
> 
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.