[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 2/6] x86/setup: add missing headers
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 14 Aug 2023 09:38:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zwuEGgs4k31BocMir/ftFDsWnxydLEP34wxuBjdVGPM=; b=OAxgCk3g1nSQNpF1hn2S5dAd3SUxB7P0V1BuTwCS0ejDO0rhBLC51drIi89ytfVLq5Z3O+Ew98H10AJ3hteh6hz/SMehR/T1Jj+Dc28QEBX9tdhsh+qBumFgGnDfnpH1SyhSNpdlkNs+LpxcvslL8u27l2VjiSSnIcmaAN332ZGhqA+NFpUrLf10hbuoU0lKTZM/5aCMCVZKU68NLLnSvhiC0OIi4lwrEpiE0nVgDIism+8UPmm6kors3KENgC0p1SJKKEeEL9YJlEybbMdaqPh2XGtl0apV/UKYxT5p0AjACR5Mg41hk0xfQThfTNI6DCwz0LlYHEeDZPNLzYNTtw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mV5Kdz5XhF3u17MnVDGfnF7HnpwfjPzET7DaWChmpBhxi/7Li3wC3gPfnmLCYjBJGKZQrM6teq3JP9DbK+QUGPVyt/S3ljPb87XXfJvHPTnmf+JvmAnxI4ymu2KVxKsT0BKJUn9FaZd6gZpf/pIH1iHs2J2OyvBBSMfyws3DGQ7A+imMXk+QeZFWFevSM6jRZ4bDg/qVur5S7yKNh4+So2ulYxN6ruG7nKEkUstSEFlv/URwurCwUjTmqnKxuX27vm8cmXBj0XO3VoDU0jC+B7mVoO1bfYdYHfU3cWtCczJvHa+iWLiFNZiN7cJWW50tNSh9vnEtBD2V/kEu5YJaTg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Mon, 14 Aug 2023 07:38:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.08.2023 00:58, Stefano Stabellini wrote:
> On Fri, 11 Aug 2023, Nicola Vetrini wrote:
>> The missing headers declare variables 'xen_cpuidle' and 'use_invpcid'
>> that are then defined inside the file.
>> This is undesirable and also violates MISRA C:2012 Rule 8.4.
>> Adding suitable "#include"s resolves the issue.
>>
>> The type of the variable 'xen_cpuidle' also changes according to
>> s/s8/int8_t/.
>>
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>> Fixes: 3eab82196b02 ("x86: PIT broadcast to fix local APIC timer stop issue
>> for Deep C state")
>> Fixes: 63dc135aeaf9 ("x86: invpcid support")
One request: Please can you get used to putting the Fixes: tags first,
so one doesn't need to (try to) remember to move them in the course of
committing?
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
