[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [XEN PATCH 5/6] vpic/msix: make 'get_slot' static
On 14/08/2023 09:44, Jan Beulich wrote: On 11.08.2023 09:19, Nicola Vetrini wrote:The function can become static since it's used only within this file.This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absenceof a declaration before the function definition. Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>Fixes: b177892d2d0e ("vpci/msix: handle accesses adjacent to the MSI-X table")Nit (typo): In the title you mean "vpci/msix", just like this quoted commit has it. This is important-ish because we also have "vpic" elsewhere in the tree. (Can certainly be adjusted while committing.) Jan Yes, I meant to write 'vpci/msix'. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |