Re: [XEN PATCH 6/6] drivers/video: make declarations of defined functions available

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 14/08/2023 10:12, Jan Beulich wrote:
> On 14.08.2023 09:56, Nicola Vetrini wrote:
> > On 14/08/2023 09:47, Jan Beulich wrote:
> > > On 11.08.2023 09:19, Nicola Vetrini wrote:
> > > > --- a/xen/drivers/video/vga.c
> > > > +++ b/xen/drivers/video/vga.c
> > > > @@ -9,6 +9,7 @@
> > > >  #include <xen/mm.h>
> > > >  #include <xen/param.h>
> > > >  #include <xen/vga.h>
> > > > +#include <xen/console.h>
> > > xen/vga.h, which you move the declarations to, is already included
> > > here.
> > > Why the need for xen/console.h?
> > vga.c needs a declaration for fill_console_start_info, which is 
> > declared
> > in console.h, as
> > stated in the commit message (it could be clarified perhaps).
> Ah, I see. It's not very fortunate mixing of two separate adjustments.
Well, they are not so separate, because they both deal with what the 
functions in vga.c need
to be compliant with Rule 8.4.

> But then I'm inclined to ask: When fill_console_start_info() is
> defined in vga.c, wouldn't it make sense to move its declaration to
> vga.h? The more considering the type of its parameter?
>
> Jan
I see no downside. This change would imply having to include <xen/vga.h> 
in both
- x86/platform_hypercall.c
- x86/pv/dom0_build.c
which seems okay.

--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)