Re: [PATCH v4 08/19] tools/xenstore: move copying of node data out of db_fetch()

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 14/08/2023 08:46, Juergen Gross wrote:
> Today the node data is copied in db_fetch() on each data base read in
> order to avoid accidental data base modifications when working on a
> node.
>
> read_node() is the only caller of db_fetch() which isn't freeing the
> returned data area immediately after using it. The other callers don't
> modify the returned data, so they don't need the data to be copied.
>
> Move copying of the data into read_node(), resulting in a speedup of
> the other callers due to no memory allocation and no copying being
> needed anymore.
>
> This allows to let db_fetch() return a pointer to const data.
>
> As db_fetch() can't return any error other than ENOENT now, error
> handling for the callers can be simplified.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall