[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxl: slightly correct JSON generation of CPU policy
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 15 Aug 2023 16:44:57 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+a+aak4G/OLfOQu1+EdiSV8E4LhINIRm+POauAxF5iY=; b=dbuCB6UMbu1ncCiHZy07ZXsL2MBVyoGTR9K3MH5nnx7uDa1S8OKUzlGjpakPlVX8BBqElMrE34ut/VAWrbEHJ/yPLVERw4oXosKu84+6szUGuEWdUyxcHL8MSlctPuvhxIdksToQjowUGUGRphFd4rZwr5Zvvr8Q2eLvgcETkwKEgLKFMGjKfL/w3eI6hZ/8InQMrFhWbAcZIkyt0uRI8Xkbiol0f0pz4IFK+s02YmSnuCjIrm4B9jW/oC8MjY9xREBw5bHWvdfBBQpl1dgd0A41++6pvKQSPpBtzQZORcHRcAuWxziDvFPncv4R2NerRl98S0htOpIYQ9WeHFQ5/A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMzSDX5RieEjJ57fzEc+g/a8i+82vEoCabH8V4q9nxDC9CtYcHp8F/y3khCqbL44kW5gjja+n9yyjW/3+jAxIloIziXUsQmyqRz76XoeuaNdBxr6HBNmffapEE5Px4/kzOQ6d9qVSqR74krJytQvu+0YBOXTtkBpcMjU9IgdG2uzK1T+Aq7i0caFIaZD+ik2rhD2AyCLS7ebSY21OtznukOHYdRZ4mkqoQ5on9EZFTwLGF3g0YZ7EDYqVVryqE9P6jizoTyHoNaxiu9RvGAzy8kGsaNXuS/o1+6j8Bj5eNlwja3LipEoRRPgCXohgq+CmuCBws40+d3+74w6AynzsA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 15 Aug 2023 14:45:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.08.2023 16:28, Andrew Cooper wrote:
> On 15/08/2023 3:26 pm, Anthony PERARD wrote:
>> On Tue, Aug 15, 2023 at 02:35:55PM +0200, Jan Beulich wrote:
>>> The "cpuid_empty" label is also (in principle; maybe only for rubbish
>>> input) reachable in the "cpuid_only" case. Hence the label needs to live
>>> ahead of the check of the variable.
>>>
>>> Fixes: 5b80cecb747b ("libxl: introduce MSR data in libxl_cpuid_policy")
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> Hmm - this was included in the security backports. I guess it ought to
> go back to 4.15 (now that 4.14 is properly dead).
Depends on whether this is just a theoretical issue, I would say. Can
legacy format input legitimately be empty? If not, I wouldn't bother
putting this onto the security-only branches. (Guess how I found it.
For the 4.13 backport much of this needed quite a bit of adjustment.
Pulling in more stuff from 4.14 isn't really an option, not the least
since I will need to [at least try to] go further back.)
Jan
|
