[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 02/10] xen/version: Introduce non-truncating deterministically-signed XENVER_* subops
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Tue, 15 Aug 2023 18:32:17 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1692138742; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GX6tOIvF2bCJ1RYYPrwz+vomp1Lb9M1jZE9uMZjXNSw=; b=YdA+hgKkkj3U6rew+mETffwuDqItrp1I9Da4LOK4o/a8WNmcvUl233LSIzPICIXql8MvmQMz0YM6jsTX/6M1x48vrTIUV9ScvYau9LrvrMzqy5K+nA80AV+cy1Evo6O/3xMpA8SREOSTNaPmJPB3r8GihWQn1kcJxZmoEPER50I=
- Arc-seal: i=1; a=rsa-sha256; t=1692138742; cv=none; d=zohomail.com; s=zohoarc; b=jueAxcKrv7wdEua03zqLTvKcsh1cye/MeWF6Ow500sFiDLxSIE56FJJuRd5U8c80li8fzVNQw+1+7+nBM+xLzXFDZBbFA+oQKnEDcgQJIIbCaEjBG9mKuDpmsf9D0vH2lWPMvsg4NXFqYDB4vqrZcevv3shk6O5OcChrDz7LcE4=
- Cc: Jason Andryuk <jandryuk@xxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Tue, 15 Aug 2023 22:32:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 8/15/23 17:06, Andrew Cooper wrote:
Recently in XenServer, we have encountered problems caused by both
XENVER_extraversion and XENVER_commandline having fixed bounds.
More than just the invariant size, the APIs/ABIs also broken by typedef-ing an
array, and using an unqualified 'char' which has implementation-specific
signed-ness.
Provide brand new ops, which are capable of expressing variable length
strings, and mark the older ops as broken.
This fixes all issues around XENVER_extraversion being longer than 15 chars.
Further work beyond just this API is needed to remove other assumptions about
XENVER_commandline being 1023 chars long.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
Acked-by: Daniel P. Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>
|
