[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] IOMMU/x86: fix build with old gcc after IO-APIC RTE changes
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 16 Aug 2023 19:18:08 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6FS2bbKXyDp42lV0RI7bXU1c7JdM1KgxAv1nTGVl/wU=; b=ei88w6AT21xw3gKqm3viRG1DWVfljqk7D/j0EXLPl6NLofVkj+XUB538WlRmzNOm+QmEJXclkcekOphYmEHVnQ8KMEWMo+Kou8YFb6WucE2t8peciM096eiMpXDHM4jg2uAtZzww8QkP9gpUBGnymvuD8g/LxkNES/rIHRQvMnSWqoF7WInTAsYhxZ2yARaZnVYRWOoOY8vwXm5wtfIvXadvdE5p7AcxEAZ9H5kBahC+vNMBJ6Q0UoF+ZY7ihpYhMwqHKf1HKw4SV0zea/ul2uu69gtMEVyA8ydHfZl6kZjIRW+MDVzJgFUPQtw3J4C9bYxMiInnIZX4U3CY+XBsLw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C9xhnjlzjIjz0rao6r8/uG6bZy4T2qiMbPJkWjNYQtcRoBXpZCdIhnkbg4+a2CuVSAVoU+Lh9vH9KgpJ9TAbjalEdWtPd8YM490ArejBni3x1JGt/rsMX7AViLHX7YhPyvnWYcmkamm5BLDSrjHBHTKP6+knNABdByHfcznZ2IgZCXGEomfsPM1IJeVVilkOrwD65MaaDpvyyQbe5z1ZqerC6uq0mcDV/KYB0ht1eH1pDQKXcDXrGTKbtCV7MS/V8vOnzCNFlwylMjLjQIFCeyFpuM5bmYvzIN8EyX/S64XHFBO2tHzN9ogi4obTZngF++m3vGns94EgIME62McSVQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 16 Aug 2023 18:18:42 +0000
- Ironport-data: A9a23:J99lgaOjaGmPIGDvrR2SlsFynXyQoLVcMsEvi/4bfWQNrUol0mAHz GVKD2vSOvrYMzf2fYt/Pork80IPvMXcmtc2HAto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGjxSs/vrRC9H5qyo42tI5wJmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0t5xICJS0 KIyEgAIRzbfnd2O2pupQMA506zPLOGzVG8ekldJ6GiBSNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PpxujCIpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eWxHKmBttLSuzQGvhCv1/Q734YGBovagGnpsOCgBfgY8J4N BlBksYphe1onKCxdfH/VRClpH+PvjYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWWRGyc8PGIrDq0ESkTMWIGIyQDSGM4D8LLpYgyilfDS4hlGavs1tntQ2iom HaNsTQ0gKgVgYgTzaKn8FvbgjWq4J/UUgoy4QaRVWWghu9kWLOYi0WTwQCzxZ59wEyxFzFtY FBsdxCi0d0z
- Ironport-hdrordr: A9a23:SK2MWKA3fiof5LHlHela55DYdb4zR+YMi2TDt3oddfWaSKylfq GV7ZImPHrP4gr5N0tOpTntAse9qDbnhPxICOoqTNCftWvdyQiVxehZhOOP/9SjIVyaygc078 xdmsNFebnN5DZB7PoT4GODYqkdKNvsytHXuQ8JpU0dPD2DaMtbnndE4h7wKDwOeOHfb6BJaa Z14KB81kKdUEVSVOuXLF8fUdPOotXa/aiWHSLvV3YcmXKzZSrD0s+BLySl
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/08/2023 10:51 am, Jan Beulich wrote:
> Old gcc won't cope with initializers involving unnamed struct/union
> fields.
>
> Fixes: 3e033172b025 ("x86/iommu: pass full IO-APIC RTE for remapping table
> update")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although
> --- a/xen/drivers/passthrough/vtd/intremap.c
> +++ b/xen/drivers/passthrough/vtd/intremap.c
> @@ -432,8 +432,7 @@ unsigned int cf_check io_apic_read_remap
> void cf_check io_apic_write_remap_rte(
> unsigned int apic, unsigned int pin, uint64_t rte)
> {
> - struct IO_xAPIC_route_entry new_rte = { .raw = rte };
> - struct IO_xAPIC_route_entry old_rte = { };
> + struct IO_xAPIC_route_entry old_rte = { }, new_rte;
Any chance we can make this = {} while at it?
~Andrew
|
