[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] IOMMU/x86: fix build with old gcc after IO-APIC RTE changes
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Aug 2023 08:37:07 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KgQ/JnBa+rmrmqj/nxwdwlFzgW+t5lJOR66odM4vAYU=; b=W8RAxJUxb8mxrhMeqnmbi/xBQ3Uy0gsfP5M6K04v1zOI/ahH9zxMfQBI5poHyrM5sxfgalnB9BQep0mMkFF+2v6sqeWzKpHixCytE9qneFEvkGtOu/+0p+wwogwXGK7UVuPQqQPVbY0E2r4W+g/86UhrQPZpubNoAAnAsWMTdQhqm/lNTLlB2VH6IRBO3kBxuFfT3vyAJONJXRTX9MILowWzSMfYPr62hFxg8jtJK8IbakX5Y9c7O+f81OOf7qGkkwWK8yc6ZSBadQ+TSZddsmY/zX8Ywo6GwIVYqq2yZ6H/VVtyCHTezW4O8tW+/p94/RhwHVVgXrdzFDgd9DGdgg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vz90i84v+fi3L524iXtP33V5O7ciyf6n7KPCzZDLVJIaTuCGbqIR/JV4+MtMYnH+yFyakMN401g0DwOhNIS4KsgJNZ1zq6h/VvYy1pAvBlz7dLp26fS0h3U1YH4lZ/N9dHuXVVxR9NZJZ5dUn9DVvdNNzWTxNR4s1u2UcQvlAjLx8q7y1rgPlL9D8frTi/B0RR3mUE5eSsJvfbynK7TZ3mMesWRx3k1e+fvDNl7vEDHrchgK9k7zl7CM3eMcStHFXMkF7aGEL2uPEr2mvc7BIQSjYfVljUA7E0n+yf0ffb1grJRiDvYMdTXY6GVnJkvMZXtpRSLeLekdv2kqjCfVJQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 17 Aug 2023 06:37:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.08.2023 18:40, Andrew Cooper wrote:
> On 16/08/2023 10:51 am, Jan Beulich wrote:
>> Old gcc won't cope with initializers involving unnamed struct/union
>> fields.
>>
>> Fixes: 3e033172b025 ("x86/iommu: pass full IO-APIC RTE for remapping table
>> update")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although
Thanks.
>> --- a/xen/drivers/passthrough/vtd/intremap.c
>> +++ b/xen/drivers/passthrough/vtd/intremap.c
>> @@ -432,8 +432,7 @@ unsigned int cf_check io_apic_read_remap
>> void cf_check io_apic_write_remap_rte(
>> unsigned int apic, unsigned int pin, uint64_t rte)
>> {
>> - struct IO_xAPIC_route_entry new_rte = { .raw = rte };
>> - struct IO_xAPIC_route_entry old_rte = { };
>> + struct IO_xAPIC_route_entry old_rte = { }, new_rte;
>
> Any chance we can make this = {} while at it?
Sure, no problem at all. To be honest it's not really clear to me whether
we prefer either form, and if so which one.
Jan
|
