[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ns16550: add support for polling mode when device tree is used
- To: Oleksii <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Aug 2023 14:06:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4mPtjayPNCJ8hjLQ4QXzKVfpGJcoAG3WNasPcDQcPaE=; b=Vv4Mtrmkxs8NeMNvjxaRB8XLHLlFcYUAk+RytlZ51MmlMWSJ1XTVBIjOKXO/ws2WnMayB64yrSm2nWHGdZfnMHxf5vGGjJwiR0hRJ9s1OZnW1jd2db8hGg6rX4GSad8iHU1Ed8H2MWCfu5KhGzrlWOlChl25eFwff+X2R5BCBmieIUfw3jjsFx/6/j2VO/kTNtm0pRZqwNw3D4Ie4GU/WCdjqWbOzy2JZYy3TH/+B8z5cVECzaJNrnyIBFjok4Ha1vhLjRvDrTDW1BvNvd3yqRGlLTF43Rq/iBXDXiCXj+YkPanbvD/u/tiIDJEvPiWTn2iombFjDpVSVwgvTo6tbQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BnKF0xnDoYxOObnccClGZ5Pzvm6dbh3nxj1eq/7Lzme6gFR6TDjUSyt9y1+gFI4oRdK81JXetH6aNIpnB9MsjL57tXnsG6sQZMhHoHKn1jC0eTt5aZg4O2+RCUSNgAWgQ7HeJaNcfPX5IYyTpDhpCrkW5m9/RmFtRJ2/zLQ3H49vnzS1OixJrvZZhDXP+G6zRjG52InnwBOWW8HKpEfLql5iO8rx1UCa0lLYQGhmcyzrgTdKgOwA8HwtDmBqx5MycNEu5K0UAhkvhKJv1sStsTCOOK3VjS0wYm+3qbAUk6lFUJnNhB/JrRYrqqQa2Egwwf0RSTEI1nkSIejNWAjYVw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 17 Aug 2023 12:06:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.08.2023 12:32, Oleksii wrote:
> On Wed, 2023-08-16 at 15:39 +0200, Jan Beulich wrote:
>> Plus the question remains of it necessarily being com1: Is there no
>> way with DT to have multiple serial ports (e.g. one for the console
>> and one for a debugger)? If there indeed isn't, then unconditionally
>> using opt_com1[] here is of course okay, but then opt_com2[]
>> is effectively a dead variable and recognizing "com2" on the command
>> line (rather than spitting out an error) is then also a mistake. IOW
>> in that case both would want keeping x86-only (with a new #ifdef, as
>> we certainly don't want to have com1 and com2 stuff in separate
>> places).
> Actually it can be even more serial ports. For example, I have a board
> with 3 UARTs ( serial ports ).
> In this case, it looks that I should have 3 variable of opt_com{1-3}[]?
Well, this suggests there's a general shortcoming of the DT part of the
code here. I'm afraid I have to refer you to the Arm folks for guidance.
Jan
> Taking into account that opt_com{1-2} variables are needed only for
> configuration of serial ports in X86 ( in DT-based architectures all
> configuration info is inside a node of UART ) then we can check only
> opt_com1[].
>
> ~ Oleksii
|
