[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 3/3] drivers/video: make declarations of defined functions available
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Aug 2023 15:28:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5cnVk1mtWfJlXSHWhkXWp2TABStuobs0s1/gNl8oOH0=; b=Un9GbUnagfqeOMrbaSVYcI8Clrr4V0Dm37gdfbDowg21xJBAz3CbACcQ/2r2qxEFeL3RyQicXkXfZzdEV/wM4NFaY/CXf12uX1JCkf7CkKZlRq9Nw4U2yl98ma8yeycmPoflvau6c2cQQ2Pp8CSs06f/syxIFoHG91TaBEcFt3ZqB0AvnbEWkC3g+DBZtVxFndz82ubX5P9mRWCZvcgYFYYRI/zXgI2CRFBGeQ/mU0yP92OqnGB4CjN5dwf7L2QYW5a9yghiceMb684V0azvE18OAKXwgfb1WLaVgpMH+P7Q5gIVzj1JuSNtkkAFxqbLTKZ0SJY/LeRIEvvC60lVSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bxGKwfDZ8WDFzmkcTpBkJ3niKK9rbUvgdN2+L2MZ77gQtmz+Wf4O2/6NySGTtg7aTvUwL2geIYZGKVwGztNyXJJAe0fQidWMr3qChjRwZntC4SayY2v9xzAhULKZPleh/RqkFENFOIN4hwBliMUpeZkvEd7E6QZWJImsFhljGovaw8Rf90KEwhVyio763hgUd95vmSF91mcB0gnW8KL4VTnhQHSPAKZKJQWxH6/AVKqEpIxLJnKbOueoGQPSjGaBCDlOfpKYwmU09L4IBM67vAIiXb0+k66Giegm1Y9AwvpyJNEevpTzSt7R29KJJtLzvZuF6HTBDzjYqXNAgkkwHw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 17 Aug 2023 13:28:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.08.2023 14:39, Nicola Vetrini wrote:
> --- a/xen/include/xen/vga.h
> +++ b/xen/include/xen/vga.h
> @@ -15,4 +15,20 @@
> extern struct xen_vga_console_info vga_console_info;
> #endif
>
> +int fill_console_start_info(struct dom0_vga_console_info *);
> +
> +#ifdef CONFIG_X86
> +void vesa_early_init(void);
> +void vesa_endboot(bool_t keep);
> +#else
> +#define vesa_early_init() ((void)0)
> +#define vesa_endboot(x) ((void)0)
> +#endif
> +
> +#ifdef CONFIG_VIDEO
> +void vesa_init(void);
> +#else
> +static inline void vesa_init(void) {};
> +#endif
Hmm, on one hand you simply move existing code here. But then why don't
you leverage the existing #ifdef? The more that it's more specific and
in line with drivers/video/Makefile having
obj-$(CONFIG_VGA) := vga.o
and
obj-$(CONFIG_VGA) += vesa.o
Jan
|
