[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/arm: vgic: Use 'unsigned int' rather than 'int' whenever it is possible
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Fri, 18 Aug 2023 09:02:41 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JAKrpvgdMwKNxemFf7MSsdZWjuNYAwyagXvDGouy83I=; b=RUJMeF9i3JOVD2O34Dke+sX5VYN8WV7/nULmTIqItBn8R2h2GnNDQe5p+NCD5mNSSRg+fL6uEqKEu2hqhijO4TpfZOLhwHtnmcQ7WeyWeGEAkBtpPJjMEGDQ8iQwdaOD9YDrhN+r/BOZ+25y//yeA2gijSMBx1vP59p72DtmiyIJEkVxlkbElcbuz1S0d0LsY2fM159cNpgL7U1ZGcMIY7oKTIJGpnHpB9OZFcnBU5kIZTRwE20FE6PaiJNvmPyl1IuDm/lnfYlSYb8VwaPzYk+iw5+VbUo4jCrUIcIyZVUvaDXpU8LHfwH0QiRrFRCsB9MKK5DPpNNdcTe61QBvqQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BnRHVIhU8FLRJpDBVBr+tDgKvJHZECjy2k6KjB2PqF9SZvrv7Ng6tvH0VbuHcFKbkTbWu0dla07sjO0XPA3I/Cxm1I2lG8I2UE2hcIf74LAcEe5UAJjd+dehMiFPxSZhw+xT4d5H4l1GMyuXkcvLLIw3sa13fHkvPYt8V3IftCbt4LALhdokmHIZ0C+aFCC5Bp96/V+59HhKTr2rs2oIFQL+Th8bGwOLwCPNMk07dmUPwPxRuaNf1yzzz9afMnlZpNNGSJMGPk4QKRutvCkWHUSrrNN6ZEN22Q2QH3be1hpULiD6iSUccIFuvsrsNP0coateK1CST4kejMMdVbI8DQ==
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 18 Aug 2023 07:03:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Julien,
On 17/08/2023 23:43, Julien Grall wrote:
>
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Switch to unsigned int for the return/parameters of the following
> functions:
> * REG_RANK_NR(): 'b' (number of bits) and the return is always positive.
> 'n' doesn't need to be size specific.
> * vgic_rank_offset(): 'b' (number of bits), 'n' (register index),
> 's' (size of the access) are always positive.
> * vgic_{enable, disable}_irqs(): 'n' (rank index) is always positive
> * vgic_get_virq_type(): 'n' (rank index) and 'index' (register
> index) are always positive.
It looks like you forgot to mention the modification done to 'vgic_get_rank()'
With this addressed:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
