[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] xen/public: arch-arm: All PSR_* defines should be unsigned
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 18 Aug 2023 10:14:30 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rX5yTIMKl0OSHj4hqeC/htkQOguWaynh/od218oFkNk=; b=OocsnsmS+a0TbglNP8mWcEZzydG93+52KgreeHCf8fcfIU6W+A9eZPg1XkFZxqxg0quV4Auza5kiqFofBpRM7qV09NyAaP5df+ayv7ZA9VSJmJpb2+bXw77bOvOJh2D//Us/hvwPSkh7sf7d5XrdbQlsq+cKQ3eURv5cCvy7VVmphPdFaw/pzTlglj2/vPCE+ZH9Ioa3y/15JKwvMfFIIJLCS0pdYDBiW/bCPScpN4Ieg6XoBFWvA+KeE1glGDNNy8Jn72FY0CiVI60zSnj9vT0i9VX2b7+680d10DYfxc73xQVs9s+UglczwH3r/XDciHljnKQnhiPQb2CKS7tKKg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aYS4jZvIoU9IDeZy3I+ipLeq5rFU8RcRzS34R7DG0Y16ygtntARz/JLFwpekQQFVKhHAjHQvxTlq5EgnFIypbja5Gra4R4wcRwy7B+KKQClzRMmuCDvKN31jhk2Y+TgWTP2yW5/bMSPeqf/F3X9/NSnxDXXRyiz5tw8aGY9CoiT1CRP84GiSQVwQ+/m8keCcmXF7LWp3uCX5KDBX/aBc+u1PbInVm6bRhFGIT8ATDKLIaaqlJY+TNrsIzOXws2Kco6A9Hh1erZCWZaKvDuepWV6oiXMLNwuAuZ+xlC6Mq/V7xKMhI/IHn84pzdPOmmqjCxfO6BHkcbprPIaBsfb2og==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 18 Aug 2023 08:14:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.08.2023 09:39, Julien Grall wrote:
> On 18/08/2023 07:33, Jan Beulich wrote:
>> As an aside I wonder why they're here: They look like definitions of
>> processor registers, which aren't under our (Xen's) control.
>
> I agree they are not under Xen's control. However, they are used by the
> toolstack and IIRC back then they were not available in any other headers.
>
> Note that they are only available by the tools and the hypervisor (see
> #ifdef above).
Yes, I did notice that (or else I would have used stronger wording).
>> I ask in
>> part because the presence of such constants may then be taken as
>> justification to add similar things in new ports. Yet such definitions
>> shouldn't be put here.
>
> From my understanding we are using the public headers to provide
> macros/defines that are used by both the toolstack and the hypervisor.
> If they are not meant to be exposed to the guest, then they will be
> protected with "#if defined(__XEN__) || defined(__XEN_TOOLS__)".
>
> I think we are in a similar situation here. So it is not clear where
> they should be put if we need to share them between the hypervisor and
> the toolstack.
On x86 we simply arrange for certain hypervisor headers to be re-usable
from the toolstack. See in particular arch/x86/include/asm/x86-*.h. And
of course everything under include/xen/lib/x86/, but those are our own
definitions, not ones meant to solely express relevant hw spec aspects.
Jan
|
