Re: [PATCH v4 14/19] tools/xenstore: merge get_spec_node() into get_node_canonicalized()

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 14/08/2023 08:47, Juergen Gross wrote:
> Add a "allow_special" parameter to get_node_canonicalized() allowing
> to merge get_spec_node() into get_node_canonicalized().
>
> Add the same parameter to is_valid_nodename(), as this will simplify
> check_watch_path().
>
> This is done in preparation to introducing a get_node() variant
> returning a pointer to const struct node.
>
> Note that this will change how special node names are going to be
> validated, as now the normal restrictions for node names will be
> applied:
>
> - they can't end with "/"
> - they can't contain "//"
> - they can't contain characters other than the ones allowed for normal
>    nodes
> - the length of the node name is restricted by the max path length
>    quota
>
> For defined special node names this isn't any real restriction, though.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall