Re: [PATCH v4 15/19] tools/xenstore: merge is_valid_nodename() into canonicalize()

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 14/08/2023 08:47, Juergen Gross wrote:
> Today is_valid_nodename() is always called directly after calling
> canonicalize(), with the exception of do_unwatch(), where the call
> is missing (which is not correct, but results just in a wrong error
> reason being returned).
>
> Merge is_valid_nodename() into canonicalize(). While at it merge
> valid_chars() into it, too.
You don't valid_chars() anymore. So the second sentence can be removed.

I can do the change while committing.

> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall