Re: [PATCH v4 19/19] tools/xenstore: move xenstored sources into dedicated directory

[Julien Grall <julien@xxxxxxx>]

Hi Juergen,

On 18/08/2023 13:14, Juergen Gross wrote:
> On 18.08.23 13:22, Julien Grall wrote:
> > Hi Juergen,
> >
> > On 14/08/2023 08:47, Juergen Gross wrote:
> > > In tools/xenstore there are living xenstored and xenstore clients.
> > > They are no longer sharing anything apart from the "xenstore" in their
> > > names.
> > >
> > > Move the xenstored sources into a new directory tools/xenstored while
> > > dropping the "xenstored_" prefix from their names. This will make it
> > > clearer that xenstore clients and xenstored are independent from each
> > > other.
> > In term of naming, I would prefer if we follow what was done for the 
> > console. I.e:
> > xenstore/client: All the clients
> > xenstore/daemon: C Xenstored
> >
> > This would avoid the one character difference between the two 
> > directories.
> Yes, that would be the alternative (apart from renaming the xenstore 
> directory
> to something different, e.g. xs-clients).
xs-clients would be OK. I guess you didn't suggest xenstore-clients 
because it is too long?
> The reason I was leaning towards my solution was that the clients are 
> meant to
> be used with any xenstored implementation. This wouldn't be reflected by 
> using
> a common tools/xenstore parent directory for the clients and C xenstored.
You have a point. I was also trying to avoid to have too many directoy 
in tools. But we already have 'qemu-trad' and 'qemu-upstream'...
> In the end I could live with your proposal, too.
My main concern with your proposal was the one character difference in 
the name. xenstored and xs-clients/xenstore-clients would work for me.
Cheers,

--
Julien Grall