[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Rombios build fixes
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 18 Aug 2023 14:18:03 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GbePUAEHyuEsP1r6aofGGlt/5LQiCW/v7+1psjgEzVw=; b=jAfRLYqSFijVGyQsjVeBVL6JhsvAHvRWRiB0H+lB72Yd03namfaF/NH2kB9znEzVzcUZV6x4sZmDPaF3iqlzdgreezVUxpAxoDt8eKBvCsnHmhKT+dhDU7CODJ6/VoeutaSnjNJijjxJulfVvQamJZyn0SFAfY6dNfjt3ssAkl9wogGywUOoP6vocxpPgCKg3jxAsem42NLMN0DOTdv3mdCXpdHClZxzDlbAsLXAJt+krh4ZdMamopvQSvspqAgerO5vx8DnxbTKhYqKUz96fR9JzLpiplDXa3/Wgmc/PLTvLWSuocDbHjybADeVlGtzxz9hYsWqhvt8AYX8Bbd00A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lwSbnVd6A+2yRAGrqWD5stm5z3rFxzCqLbTHOOyfBPjdQGsuZl4t+YAw+Y8lUG5iWbDIJNcCyM/4oFjXzvsPxyK2dHEJL4Rpy6gmiskd+t3YhTrdtaDzlpj03/53154Ox6nKhVkievOCP85R5mTd2UW6pK3RunMj7mme0OacaG2TqhJO2ONVfnMPm3IdZe+ANzmWX5WGnrKOGH76AwZSAaOqO2SfAb7twx4EvHIkghtMybKRb2e5Nk+fclB2et52pr3mlORy3fGfQhigDt1Tv0kN1ALMGFB51cm3xMDWsfrCD1pw9yOL5lKEVzkP08fxixzEbU/r37AuXRUrzIwm8Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 18 Aug 2023 13:18:39 +0000
- Ironport-data: A9a23:l3FAVq/tdXvbnrqWMBNFDrUDrX+TJUtcMsCJ2f8bNWPcYEJGY0x3n DAdWzqPOanYamr9Kt8nbIS2oUMEupHWxtdjSVRvqnw8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ird7ks21BjOkGlA5AdmNakb5AW2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklV+ 60AMhIgVyzEitDsxLbiS+o2vc48eZyD0IM34hmMzBn/JNN/GdXmfP+P4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWOilUpj9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdtDTeLhr6cz6LGV7kBKN00rfBy/mvSSkGKxVowCM 3IQ1AN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxmdLngJSHhGctNOnN87Q3km2 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgc/iTQsSAIE55zmv9s1hxeWFtJ7Svft0ZvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztp6s8K7xooG9g UU5
- Ironport-hdrordr: A9a23:S+zToa165VQRFcoyf/CI+gqjBB8kLtp133Aq2lEZdPWaSK2lfq eV7ZImPH7P+VEssRQb8+xoV5PsfZqxz/JICMwqTNSftOePghrVEGgg1/qe/9XYcxeOidK1rJ 0QDZSWaueRMbEKt7ef3ODiKadY/DDvysnB7ts2jU0dLz2CDZsO0+4TMHf/LqQZfmd77LMCZe uhz/sCiTq8WGgdKv+2DmMCWIH41qf2vaOjTx4aJgItrDKDhzOw6LL8DnGjr2wjegIK77c+0H TP1zf07KW7s/2911v12mLJ445N8eGRuedrNYijitU1Nj6psAquaYh7MofyxAwdre209VYsmM TNpRA7Vv4Dm0/sQg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/08/2023 2:13 pm, Jan Beulich wrote:
> On 18.08.2023 15:05, Andrew Cooper wrote:
>> On 18/08/2023 1:57 pm, Andrew Cooper wrote:
>>> Andrew Cooper (2):
>>> rombios: Avoid using K&R function syntax
>>> rombiosn: Remove the use of egrep
>>>
>>> tools/firmware/rombios/32bit/Makefile | 2 +-
>>> tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 10 +++++-----
>>> 2 files changed, 6 insertions(+), 6 deletions(-)
>>>
>>>
>>> base-commit: e6cb27f2f20d09dd2ba135fbc341a4dc98656e10
>> Urgh, forgot to write what I meant to write.
>>
>> https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/972116359
>>
>> This gives a clean CI run when ROMBios is explicitly (re)activated.
> On irc you said "more array bounds issues in GET_BDA", yet nothing further
> is being adjusted here in that regard?
So yes, I did end up being confused about those.
They're from the iPXE build, not the RomBIOS build. They can be seen in
https://gitlab.com/xen-project/people/andyhhp/xen/-/jobs/4899807239 but
there's clearly no -Werror going on.
I'm going to leave it for now. The only reasonable fix would be to bump
the version of iPXE and I don't have time to that right now.
~Andrew
|
