[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/svm: invert valid condition in svm_get_pending_event()
- To: Jinoh Kang <jinoh.kang.kr@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 18 Aug 2023 20:42:35 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V8ebfZtuIkfEJ0Dp+1DtTUHn40roQlWG7LfYvdzPDg4=; b=gZAQrNWaAt4FuS6R4Ot+Idu/6SXPopd0gkjNEEazLPFfz3CezVLK/OUw/6ETwlQ/1jnMhNTJq9O+/MLyd3Lrca8mIBrLGCyi6L1SWTCUZltO9hyNi29euBdubjKYKZiHPiql2BSbNU+y6iQn4XV89xiskHNVrH1MPrMdNXByOUDkU5ZgdZMlAG5UamuK8KFdl7SdniD5G7p+ASMiKJR89+I4JagOPwZ6lFMu0mnTU0j/swEgFcn8JXaByHkLHDVxYAi+yI8KZTe1Dgp3X14cAOOueyZ+EiBtWPkz9X6ufevHDgYfxIu57HiRiBWMIs3gIm7vrM7JGjYB/3oZyw6Z+g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KEtYWM/KJ5RFLDdjHks+UlsAmN95R0ThPB9jT/q6y8546yCj4/ooUYCliZP6/wpWPzaZmMNpsjBvGvJVlmITqqHxZq5nkoknPA4ksyz89C/kzplvyAqIVEn6nz7niMlYhmgAThMme3xCLVhQnDkV2yTQ3kUizsvH1IILKCZxrhct8o5ytYVgHvt2x2yTiB0D2erALWjhyALotRvVmHOY6LHMNF0vxgBa2ADrmnvm4Ud1Sf+eKcGpUQ6FgOGeqMhlSiS4d/hj5oxaZ7KMHf9K5lIyCTP5FtfWCf5SlzyRDoDb31bh330Gu9vPiUVV3HlBGBBZUlQ4f8Iwo9M+yAxjZA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 18 Aug 2023 19:43:09 +0000
- Ironport-data: A9a23:P0CDxqj4T4KP2S49ooruJOQoX161pxEKZh0ujC45NGQN5FlHY01je htvUWqGPKuCYWOgLtonbN+19R9TupTWydNmSgBvr3w1Ri0b9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyr0N8klgZmP6sT7AaOzyV94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQRBjIhRUuvwNmL46CkVsluvcQBAM/0adZ3VnFIlVk1DN4AaLWaGuDhwoYd2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEvluGyb7I5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TefgraA73QHProAVIB0faQGrucKfsxa7SvJnG 1RT9wo+vJFnoSRHSfG4BXVUukWsvB8aXNoWEOQ850eO0ILb5g+YAi4PSTspQN4sudIyRDcq/ kSUhN6vDjtq2JWKTVqN+7HSqim9UQAFIGlHaSIaQA8t59j4vJp1nh/JVsxkEqO+kpvyAz6Y/ tyRhC03hrFWhslS0ay+pAnDm2j1+cePSRMp7ALKWG7j9hl+eIOue42v7x7c8OpEK4GaCFKGu RDohvSj0QzHNrnV/ATlfQnHNOvxjxpZGFUwWWJSIqQ=
- Ironport-hdrordr: A9a23:9ElJpaDxkAuOn1TlHemT55DYdb4zR+YMi2TDGXoBMCC9E/bo7/ xG+c5w6faaskd1ZJhNo6HjBEDEewK+yXcX2+gs1NWZLW3bUQKTRekI0WKh+V3d8kbFh4lgPM lbAs5D4R7LYWSST/yW3OB1KbkdKRC8npyVuQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/08/2023 5:03 pm, Jinoh Kang wrote:
> Fixes: 9864841914c2 ("x86/vm_event: add support for
> VM_EVENT_REASON_INTERRUPT")
> Signed-off-by: Jinoh Kang <jinoh.kang.kr@xxxxxxxxx>
Yeah, that's just straight up broken. I'm not aware of anyone having
used this in anger on AMD systems yet.
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I've tweaked the commit message a little bit on commit, to make it
clearer what you're doing. (You're not making the valid condition
invalid, which is one interpretation of "invert" in that context).
|
