Re: [PATCH v5 04/13] xen/arm64: Split and move MMU-specific head.S to mmu/head.S

[Julien Grall <julien@xxxxxxx>]

Hi Henry,

On 14/08/2023 05:25, Henry Wang wrote:
> The MMU specific code in head.S will not be used on MPU systems.
> Instead of introducing more #ifdefs which will bring complexity
> to the code, move MMU related code to mmu/head.S and keep common
> code in head.S. Two notes while moving:
> - As "fail" in original head.S is very simple and this name is too
>    easy to be conflicted, duplicate it in mmu/head.S instead of
>    exporting it.
> - Use ENTRY() for enable_secondary_cpu_mm, enable_boot_cpu_mm and
>    setup_fixmap to please the compiler after the code movement.
I am not sure I understand why you are saying "to please the compiler" 
here. Isn't it necessary for the linker (not the compiler) to find the 
function? And therefore there is no pleasing (as in this is not a bug in 
the toolchain).
Other than that, the split looks good to me.

Cheers,

--
Julien Grall