[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/13] xen/arm64: Fold setup_fixmap() to create_page_tables()
- To: Julien Grall <julien@xxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 21 Aug 2023 09:30:29 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0K1r+xUuTlNBa/CQDe3Ur6xvmag/JljLlf5SeK+2ZnA=; b=iCqitFd7ZMEM+pLVwkKGlcwshs3ba1/Ma7DjjYVFN/Na4rI0mCGdc5uypNtwIJY6SQqZjqnL/1PbONIYCfVuwMIOk1Gb4SrM36KPbg19Y+To39Wdx2iq8pjTk3t1yxwwK7DpenF+q5uendhMlPMTZRi40R2MilvcsIe0fWTIgLt1a/Ho3KGKtjVST3hwvvcH+pgJRiXOmCR3YcpGoQWL73x6z1AVqwQuFrmlG+1Dux0+tcYX7QZonH5aOJcV7ew7/vGd0EuT6ZGxaYPXPEYmCxggcLu4NQGRYLorvPDykakVdMnhzquagpMU31O0jnNJHaatTlx1L2BT6n0Md1sG3w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JMKea6OIEPmRB7DePxrS9g8PS1Tf5mAlVkollUJz2UEHR40dmOEfcGm8wRvfd367sT5CcjRFEl5CRwzxNd/vuTwj+TiCSQj+bpjPU/hw3WxTZlf4PKo9tC4hbt6drR6kyP8iOiIjXg8AhW2tGEwf0yztS7Rhz+izqWvkAK7C9pEHZZm5y56dWEkgehO8VSHHrUnnh+UT1urrIrvqFK2aIUsCPmM931AVaJIzGXnHsIH3sl+a8ZGAIRmNfS4mUmSdHjKOj7JHVL7l3QehiYPcwdVegcLn0TuaRI3hlSm7uaGydlioqRqzzz5/yVWlYq/6hOmj8aq4S0Xha7LWeX9Q8g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 21 Aug 2023 09:30:45 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZzmd/r/JuiD2oz0+SIciGrMmW46/0hSIAgAACQQA=
- Thread-topic: [PATCH v5 06/13] xen/arm64: Fold setup_fixmap() to create_page_tables()
> On Aug 21, 2023, at 17:22, Julien Grall <julien@xxxxxxx> wrote:
>
> Hi Henry,
>
> On 14/08/2023 05:25, Henry Wang wrote:
>> The original assembly setup_fixmap() is actually doing two seperate
>> tasks, one is enabling the early UART when earlyprintk on, and the
>> other is to set up the fixmap (even when earlyprintk is off).
>> Per discussion in [1], since commit
>> 9d267c049d92 ("xen/arm64: Rework the memory layout"), there is no
>> chance that the fixmap and the mapping of early UART will clash with
>> the 1:1 mapping. Therefore the mapping of both the fixmap and the
>> early UART can be moved to the end of create_pagetables().
>> No functional change intended.
>
> I would drop this sentence because the fixmap is now prepared much earlier in
> the code. So there is technically some functional change.
Sure, I will drop this sentence in v6.
>
>> [1]
>> https://lore.kernel.org/xen-devel/78862bb8-fd7f-5a51-a7ae-3c5b5998ed80@xxxxxxx/
>> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Thanks!
Kind regards,
Henry
>
> Cheers,
>
> --
> Julien Grall
|
