[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] docs/misra: add exceptions to rules


  • To: Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 22 Aug 2023 12:35:07 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PGuOoiNX4r4Yu6Ha5lLQw9b0S5VPebQt9k795FeBvc4=; b=ZzHVxfkLDfsjSxH/ybYiFn+FsfIEVplWFITM1Ytncpcr0uVDruOnphBCiMGoUFbs8xQquNdangvwVYijftoZfET32KDOLpxVV+Gx9uNgu9ksy/T+O0O7+oZkvN1D1el8R+VG276Hvl07z1BdiMbyjoVZ5nOLjhoyhAyOzen6YrF+Ix95B1MIwkxtlyigCKFsnmwWHX7fGXDUzai0j2zGgwDdPeYxD+M3Mz4eVR81OPOgWuECIQiAzW7IO7sKFvWi+bHK/EalQFmrpxpqfxk5kKC/PT9PhZSPmWqEt+YZGfgPfk+oLIf75HBtjVetSQTUZo1TDODvoM+nC9icR1AW4g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H/VceEl59zgkhMkYw8YJFHpI90EmRrQ3fp8mxNHW+7LOmvPvB4hamxam17y4uONKrvTDL3haOVX54lN730DupFsx5Xr3CbXSuho2CJFXbN/hYy2mD0275ftV8IGl/leqokZ9h5CJy2AgAWinzX3qgR4oN2yw1n66GfuXhBqp6gdCZdVxADzGedylAYforqUWJXrIfSIzwP69L5tLcbaJ8C4FMnPbgmNzGv0sRD9nR8CJDZTE9iXbfZpEC7dnrOMY3raZrYV7SBh7TLY7MV4QxjdzyvUP2LnjeT9HL60lyrGGR8QHR3GRvYkdQAqnCr+jkEGx5QxnB5tqxhJjoJ550g==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, bertrand.marquis@xxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 22 Aug 2023 10:35:14 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 22.08.2023 12:33, Julien Grall wrote:
> Hi Jan,
> 
> On 22/08/2023 11:12, Jan Beulich wrote:
>> On 22.08.2023 09:56, Julien Grall wrote:
>>> On 22/08/2023 02:30, Stefano Stabellini wrote:
>>>> --- a/docs/misra/rules.rst
>>>> +++ b/docs/misra/rules.rst
>>>> @@ -59,7 +59,8 @@ maintainers if you want to suggest a change.
>>>>         - Required
>>>>         - Precautions shall be taken in order to prevent the contents of a
>>>>           header file being included more than once
>>>> -     -
>>>
>>> It is not clear to me why this line is removed. Was it added by mistake
>>> in a previous commit?
>>
>> The patch is replacing an empty comment ...
>>
>>>> +     - Files that are intended to be included more than once do not need 
>>>> to
>>>> +       conform to the directive
>>
>> ... with a non-empty one.
> 
> I understand that... My question is more related to why we originally 
> added one? If this was done on purpose, then why are we removing it?

I think the goal is for the file to be easily machine readable, and hence
the same number of sub-items want to appear for every main item.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.