Re: [PATCH v1 44/57] xen/riscv: introduce asm/vm_event.h

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Mon, 2023-08-21 at 18:43 +0200, Tamas K Lengyel wrote:
> On Wed, Aug 16, 2023 at 12:30 PM Oleksii Kurochko
> <oleksii.kurochko@xxxxxxxxx> wrote:
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > ---
> >  xen/arch/riscv/include/asm/vm_event.h | 52
> > +++++++++++++++++++++++++++
> >  1 file changed, 52 insertions(+)
> >  create mode 100644 xen/arch/riscv/include/asm/vm_event.h
> 
> I don't think we ought to replicate this header for every arch when
> clearly the functions in them are only relevant for specific
> architectures. Would make more sense to me to just conditionalize the
> caller side to the specific archs where these functions are actually
> defined, which would largely just be CONFIG_X86.

Thanks. I'll take it into account.

~ Oleksii