[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v2 2/3] vpci/msix: make 'get_slot' static


  • To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Wed, 23 Aug 2023 16:14:30 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fUsrN5T4FZnQblj0u5TDFm71/MJW8OASu6ZHgaa0RE4=; b=L3nlbC+7VTO1K9KelypyCVW5iFQU6ai67Wfo6Fo2nB9AkPwxrVp5c3LZOu4SMVOjul3sBWio+IuJbW1owZKgMPPrzTEGDHc22zZJX6Iz6Fc6r6noh9SRTNZNh2ZYxS8A+EkvNwlej9P2j3nvODXjJKiJkRXPd1KL4N5TjhXN0a53z4ORrPVqaTU/rx+XSb4TrFs5ozeFGyDw37Wu3yE/VBxzCuw3Sr0ktuH9BNZNug4owUpQ0feXbT69eW/ZGXj1g0zRUA41DVSaHoikRo1T9gXJYx7olPgkt7HTIPcn2aBiUlKhFEI5oLMnOM/s24My1C2TgQdWL3gQ6HFr3zwqgQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RibFO8GnMhp5HUnQsJAog2OxQlt5fcd8DGF0qzJ32oBx1cFCMcSH7jidkbbi0fy46jpdSBbIWZc85pjy7h27pPFe8tQTKQfOzgt9kfOv/1DtsHxsHcO14TIdkKzks7BB2TLisAoDG64HoKa343MHwL3YNIzCgvb+K3EmAlAjDZOnNm2Dh3GpEJhVnxGaRGs1Zz7w8atRZNXYk4c1YhchsCKOHZ93cRxm20+DgzvODt5lQdMgnq89AXmrkDJXFYckE9P9IlopSb1P/U55ALYt+glfsQ61nkx61h8AJqblLI7i+XEEFrrZH7+P29xV05kOHX2/EHALT0T1AHKJhxZbMQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 23 Aug 2023 14:14:45 +0000
  • Ironport-data: A9a23:rNZudKJ+O4klINRSFE+RnpUlxSXFcZb7ZxGr2PjKsXjdYENShGYHm 2QcXjzXOf+PYmOgf49wYY209B4AvsXUm9NjGgtlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA7gZlPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5JKHhu6 f8zAgw9QVeemv+K8qqxbtVz05FLwMnDZOvzu1lG5BSAVLMMZ8CGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dnpTGNnWSd05C0WDbRUsaNSshP2F6Ru 0rN/njjAwFcP9uaodaA2iv23rOWxXKhAur+EpWA/PM70E+36lcCJyMxRwGBhdSJhmOhDoc3x 0s8v3BGQbIJ3EqqRd75VlumrWKevxgdc9BNHPY37g7Lwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313qyPsTq4NCwRLGkDTSwJVw0I55/kuo5bphfORdZqFOiylM/4HRn5x jzMpy87750DgMgK3uOh9F/Gij6lpZ/UZgcw6kPcWWfNxgpobYjjZJGt4EKd7f9EIIuDZlCEs D4PnM32xOsJC4qQkDCMRuolFqym/PuDP3vXhlsHN5s88zWg/VazcIYW5ytxTG9rOMsZfT7iY GfIpBhcopRUOROCcqtfc4+3TcMwwsDd+c/NU/nVap9EZMh3fQrepSV2PxfOjibqjVQmlrw5N dGDa8GwAH0GCKNhij2rW+Ma1rxtzSc7rY/Oea3GI92c+eL2TBaopX0taTNisshRAHu4nTjo
  • Ironport-hdrordr: A9a23:FasTNKsgqrxsfAf8iQHTDDRK7skDgNV00zEX/kB9WHVpm6yj+v xGUs566faUskd2ZJhEo7q90ca7Lk80maQa3WBVB8bBYOCEghrOEGgB1/qA/9SIIUSXmtK1l5 0QFpSWYOeaMbEQt7ef3ODXKbcdKNnsytHWuQ/dpU0dMz2DvctbnnZE4gXwKDwHeOFfb6BJba Z1fqB81kedkXJ8VLXCOlA1G9Ltivfsj5zcbRsPF3ccmXWzZWPB0s+AL/CAtC1uKQ9y/Q==
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Aug 17, 2023 at 02:39:27PM +0200, Nicola Vetrini wrote:
> The function can become static since it's used only within this file.
> This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence
> of a declaration before the function definition.
> 
> Fixes: b177892d2d0e ("vpci/msix: handle accesses adjacent to the MSI-X table")
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Sorry for the delay.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.