[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] xen/console: Set the default log level to INFO for release builds
- To: xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Date: Thu, 24 Aug 2023 11:02:58 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1QpfZ8Y1pARBnsRsHN+REqsp6412lRLypRmEjE84+ok=; b=YqguywAP0OSsAIy0+AXtVYNRCcoY1E3xvcU9SgXa9VbVZO9oekI3n86Cp1dQX0039C4LZLBoMR+Eq3Y5hQ6jKs01UIiW+W1Ec8kGGu/Q8PVTcirKJJW3UCYv9rv/qh2QiD5FFqXHqDeHQBvVr/aH0OuQYM+GC7Y12XcUOtkpSlwy1cewQ/+PWi01WkHC/k4oVmXRjl0PhMAc1W+G05hslw+cFw1nXNEq5QYD203R2KuAvWOuKFMp7roVUvdxlwsEcWn1x5hpFwQWDA6hdWSXQ/NxUvJgLn8uUGjS37D1tiyKE32BMw1Xakz2kOWqFnJUNB8q6tR4qpnqO8OXU//KoA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XwphuLD/IVdU+C8HQJ9B4d/Nu0x3tJgjHaR/PXggyhG/zPEMr5/B4xllF3QCvJMTq/JktGdqGfITGCFxua4k+8nekn7UCsFiWHY2QB/ZVL1UzlsxMPVIx5o7u3IHwQRPpY8pxI8m+akfmWBs7HLkqKXZPNXYvBkzR5MGpSLaa91wBsmuQldNfnfmXNxFR6uIFuQVR2q5rH2pwypmd5c8mq7HIJbfHL+yy68dx+Puk0F03GfCO/gMF/T4OpRiL6GsVPsHkrS0hp96+0gu02omhaEw6jebb4pZ+va2+FLMvrWKeKxXJpO2RGHtPHi3CweIkhrAk5k6G/FXzY2ZvCuE5Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 24 Aug 2023 09:03:32 +0000
- Ironport-data: A9a23:1o1RtKDG37hyXRVW/+biw5YqxClBgxIJ4kV8jS/XYbTApGwm0zMOy WQYXGvTb/3eYmSmL9p+b4yy9R8BvZ6HnNFgQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbCRMsspvlDs15K6p4GNC5QRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwy/9MEWdEx 9IjFD0UYD7ejcOr77OZc7w57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xrugA/zyQouFTpGMDSddGQA91cg26Tp 37c/nS/CRYfXDCa4WPfqiny27SUxUsXXqofU52V1ftpuGHL6VMoCx4xa2OYjcWQ3xvWt9V3b hZ8FjAVhbg/8gmnQ8fwWzW8oWWYpVgMVtxICeo45QqRjK3O7G6xBGIJUzpAY9wOr9ItSHoh0 Vrht9H0AT1itpWFRHTb8a2bxRupIjQcJ2IGYS4CTCMG7sPlrYV1iQjAJv58FIalg9uzHiv/q w1mtwA7jrQXyMsUjaOy+Amdhyr2/sSQCAko+g/QQ2SpqBtjY5KobJCp7l6d6utcKIGeTR+Ku 31sd9Wi0d3ixKqlzESlKNjh1pnwjxpZGFUwWWJSIqQ=
- Ironport-hdrordr: A9a23:2fWuUq0tPO7O9J0z8L6nPwqjBfdyeYIsimQD101hICG9E/bo4v xG+c5xuyMc5wxwZJheo6H9BEDtexLhHP1OkPos1MmZLWvbUQKTRekJ0WKI+UyCJ8SRzJ856U 9qG5IOd+EZZTJB4foTi2ODfOrJD7O8nZyAtKPm6zNIcCkvUqdn6m5Ce3Sm+o8dfng5OXL8fq DslvauYlCbCAUqh7+Adx04dtmGncTPiJXlJTYeHnccmXCzpALt0qf+Dx+bmjwDUzZDqI1SjF TtokjC/6C+tPP+7RfZ2wbonvNrseqk8MJHGMuPzu4KLTn24zzYArhJavm5pTUop+Pq0nYG+e O82ysIDoBI8nbMeWPwmxf3xAX69z4r5xbZuCSlqEqmm9X9WDU5T/VMnphYdByx0TtbgO1B
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
Not displaying INFO messages by default on release builds is not
helpful, as messages of that level are relevant for hypervisor
operation. For example messages related to livepatches applied and
reverted are of INFO level.
Custom builds that require less verbose output can adjust it using the
command line, but attempt to provide all relevant information by
default on release builds.
Adjust the loglevel of printks that don't have an associated level to
INFO instead of WARNING, since INFO will now be printed by default on
all builds.
Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
---
docs/misc/xen-command-line.pandoc | 2 +-
xen/drivers/char/console.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/misc/xen-command-line.pandoc
b/docs/misc/xen-command-line.pandoc
index 5f388eb560c9..a3145983f623 100644
--- a/docs/misc/xen-command-line.pandoc
+++ b/docs/misc/xen-command-line.pandoc
@@ -1706,7 +1706,7 @@ This option is available for hypervisors built with
CONFIG_DEBUG_LOCKS only.
### loglvl
> `= <level>[/<rate-limited level>]` where level is `none | error | warning |
> info | debug | all`
-> Default: `loglvl=warning`
+> Default: `loglvl=info`
> Can be modified at runtime
diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 0e410fa086df..f81b8b6b47d0 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -136,8 +136,8 @@ static DEFINE_SPINLOCK(console_lock);
* the lower threshold equal to the upper.
*/
#ifdef NDEBUG
-#define XENLOG_UPPER_THRESHOLD 2 /* Do not print INFO and DEBUG */
-#define XENLOG_LOWER_THRESHOLD 2 /* Always print ERR and WARNING */
+#define XENLOG_UPPER_THRESHOLD 3 /* Do not print DEBUG */
+#define XENLOG_LOWER_THRESHOLD 3 /* Always print INFO, ERR and WARNING */
#define XENLOG_GUEST_UPPER_THRESHOLD 2 /* Do not print INFO and DEBUG */
#define XENLOG_GUEST_LOWER_THRESHOLD 0 /* Rate-limit ERR and WARNING */
#else
@@ -150,7 +150,7 @@ static DEFINE_SPINLOCK(console_lock);
* The XENLOG_DEFAULT is the default given to printks that
* do not have any print level associated with them.
*/
-#define XENLOG_DEFAULT 1 /* XENLOG_WARNING */
+#define XENLOG_DEFAULT 2 /* XENLOG_INFO */
#define XENLOG_GUEST_DEFAULT 1 /* XENLOG_WARNING */
static int __read_mostly xenlog_upper_thresh = XENLOG_UPPER_THRESHOLD;
--
2.41.0
|
